Multirun cannot find bash runfiles about bazel-tools HOT 7 CLOSED

@dimitarvdimitrov Would be great to find out which commit actually broke it. Could you see if e31d79d works

@laszlocsomor maybe you have an idea?

from bazel-tools.

@ash2k Same issue there as well. After a bit of investigation, found that there is an extra space in the grep regex at

Removing it solved the problem.

Should I submit a PR for that?

from bazel-tools.

@dimitarvdimitrov : That extra space should be there: https://github.com/bazelbuild/bazel/blob/9eb2ef0d1feea9a08161ea0f8c16e3ac0a07064d/tools/bash/runfiles/runfiles.bash#L53

Let me try to repro this error locally.

from bazel-tools.

I fail to repro this on Linux. Do you only see this on macOS?

What's the output of:

grep 'bazel_tools/tools/bash/runfiles/runfiles.bash' bazel-out/darwin-fastbuild/bin/run_all.bash.runfiles_manifest

?

from bazel-tools.

@laszlocsomor Managed to dig up the problem; it is because of my GREP_OPTIONS=--color=always.

Thanks for the help and sorry for bothering you guys with it.

Closing as it isn't an issue with bazel-tools

from bazel-tools.

Thanks for figuring that out! I wasn't aware GREP_OPTIONS existed.
Maybe I should make the script runfiles.bash init code ignore it.

from bazel-tools.

@laszlocsomor I think the only safe/deterministic solution would be to completely shield grep from all environment variables using env grep .... Same with any other programs in that script (if any) - they can be influenced by an environment variable, if not today, maybe in the future.

from bazel-tools.