Comments (2)
Thanks for the request. This seems reasonable, there's definitely a few real situations which are difficult to tackle without @container
queries.
A couple of initial thoughts...
I like they way you've extracted the name to a variable - it leans into JS mechanisms to be import/exportable and cleaning up unused code (no-unused-vars).
The name wouldn't be internally needed in styled.createContainerToken()
- we'd want to mint unique names so that they're isolated to avoid unintentional name conflicts. It might be useful for debugging though.
We will have an issue with minting these tokens because they'll:
- Need to be ordering consistent between SSR and client (the problem
useId()
solves) - Need to be order independent (
createContainerToken()
will be called depending on the order of module execution) or they'll get different values each time
Overall, it's an a bit of unfortunately dynamic piece we'll have to tackle within a project which is largely build around making sure everything is static so it can be extracted into a single atomic stylesheet.
These are resolvable, but it'll require quite a bit of shift to how styles are authored to bring them into a safe context (inside the component so they can make use of useInsertionEffect
/ useId
)
Potentially there's other options too.
Relay solves this with the global compilation checking for duplication, and enforces that you consume children in the parent. That could work here, but... one of the desires with container queries would also be to cover async cases - so we don't necessarily want to force the parent to import the child.
We could also use the type system to ensure you're explicitly connecting the parents and children here - and type imports would be stripped. TS unfortunately isn't great with nominal types, but I think it's a useful option to explore
from compiled.
One option is for a compilation step (maybe babel transform) to replace createContainerToken
with that unique symbol (which could be generated from the relative package-name + file-path) and otherwise to use the input string with order.
Anyhow the input string (which has a similar intention in that code-sample to Symbol(name)
) can be hashed as a fallback, where there is no transform.
from compiled.
Related Issues (20)
- Duplicated CSS rule in devloop if using SSR
- [ESLINT] @compiled/no-css-tagged-template-expression truncates URLs in CSS HOT 1
- Docs: Limitations & runtime styles HOT 3
- Order Media Queries HOT 6
- onFoundStyleRules is not called HOT 1
- Issue with jsx types
- Issue with package.json
- :has(:focus-visible) gives different and unexpected results to &:has(:focus-visible)
- Decide on long-term solution on ampersand in CSS selectors (e.g. `:hover` and `&:hover`) in `styled` and `css` APIs
- Throw clearer error when object property name is imported through barrel files HOT 1
- Support `as const` for object property names
- Next.js 13+ support? HOT 2
- Fails silently when Compiled APIs are used as values in style attribute
- Using object property (imported from CommonJS / CJS package) as media query results in failed build
- When using an object property in a media query, `as const` in the object definition causes build to fail
- Properties fall-through to wrapped DOM element when there are default values in the property declaration
- CSS Map has its output property types unexpectedly expanded at times HOT 1
- Types on `css={…}` don't block using the top-level object from `cssMap()` HOT 1
- Styles are lost after composing styled component and then using `as` prop HOT 1
- Passing a `css` output as a value to another `css` call fails with no type error (etc)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compiled.