Giter Club home page Giter Club logo

Comments (3)

AtheMathmo avatar AtheMathmo commented on June 16, 2024

Thanks for posting the issue!

I appreciate that this is a very quick and easy fix - but could you explain the use case for me? I ask as I don't see anything obvious myself and this will increase compile time (probably negligibly).

Also - would we not want this to also be possible for Matrix?

from rulinalg.

brendan-rius avatar brendan-rius commented on June 16, 2024

In my case, I have a structure containing a vector and I use that structure as the key of my HashMap. To be able to do this, my structure has to implement the Hash trait and this Vector needs it too (to be able to use derive).

Maybe there are some other use cases but I have not experienced them.
(If it is considered a valid argument, the native Vec also implements Hash)

Finally, if it is implemented in Vector it should probably be implemented in Matrix for consistency.

from rulinalg.

AtheMathmo avatar AtheMathmo commented on June 16, 2024

I see, thanks! I've added a comment to PR #11 . In short I'm happy to see it added unless there is a significant increase in compile time (which I don't see happening).

from rulinalg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.