Giter Club home page Giter Club logo

Comments (6)

rmelian avatar rmelian commented on August 22, 2024

Hi @RobertDiebels good catch too, do you want to send another PR :)

from generator.

fmvilas avatar fmvilas commented on August 22, 2024

In case it helps: you might need to use #unless @../last instead of #unless @last.

from generator.

RobertDiebels avatar RobertDiebels commented on August 22, 2024

@rmelian I'll see if I can create a PR within an hour or 8-9.
@fmvilas Thanks! I'll check it out.

from generator.

RobertDiebels avatar RobertDiebels commented on August 22, 2024

@rmelian @fmvilas I created a PR that should fix this. I looked into the @../last but I got the impression @../last goes to the parent object and tries to get the last item from the parent. Where the parent would be the asyncapi itself. I prefer this fix however, since it removes the need for a bunch of if-statements in the Config partials. Let me know what you think.

from generator.

rmelian avatar rmelian commented on August 22, 2024

Hi @RobertDiebels I'm sorry it took me so long to review this. This looks fantastic, I have just a few comments.

from generator.

rmelian avatar rmelian commented on August 22, 2024

actually, my only comment was to change x-service-name to operationId as this will be officially supported in version 2.0.0 of the specification but I guess it was my who implemented it this way :)

great work on this, I'm approving this PR

from generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.