Giter Club home page Giter Club logo

Comments (8)

pllim avatar pllim commented on August 27, 2024 2

Maybe the title of the issue should at least be updated, as [docs only] is no longer broken.

from ci-helpers.

pllim avatar pllim commented on August 27, 2024

Yeah, something like not right with this logic somehow but my bash-fu is not strong enough...

elif [[ ! -z $(echo ${COMMIT_MESSAGE} | grep -E "${DOCS_ONLY}") ]]; then
if ! [[ $SETUP_CMD =~ build_docs|build_sphinx|pycodestyle|flake8|pep8 ]] && [[ MAIN_CMD =~ pycodestyle|flake8|pep8 ]]; then
# we also allow the style checkers to run here
echo "Only docs build was requested by the commit message, exiting."
travis_terminate 0
fi

It looks as if [docs only] has no effect now; i.e., all the Travis jobs run regardless.

from ci-helpers.

pllim avatar pllim commented on August 27, 2024

Maybe I broke it in #407 . 😭

from ci-helpers.

pllim avatar pllim commented on August 27, 2024

I think this is now fixed?

from ci-helpers.

pllim avatar pllim commented on August 27, 2024

Oh, wait... Haven't done "if there isn't even one docs job in the travis config the hole build should be cancelled without going into the individual jobs"... BUT do we really want that? I thought we still want PEP 8 job to run regardless.

from ci-helpers.

bsipocz avatar bsipocz commented on August 27, 2024

There is a pep8 test on circleCI now, too, so it's all good to cancel the whole of travis.

from ci-helpers.

pllim avatar pllim commented on August 27, 2024

But, only the core does that, not everyone else who uses ci-helpers?

from ci-helpers.

bsipocz avatar bsipocz commented on August 27, 2024

oh, yes, you're right regarding that.

from ci-helpers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.