Failing test_image_example about astroplan HOT 8 CLOSED

This is the test_image_example I added today that uses pytest-mpl.

For some reason the image that was generated on my computer and travis-ci has shape 800 x 600, and @bsipocz, on your computer 880 x 660.

@bsipocz @astrofrog – Any idea what needs to be changed to get reproducible image size on all computers? What's the recommended pattern to do this?

from astroplan.

Differences can be due to differing matplotlibrc files. Can you both check whether you have an active matplotlibrc file?

Ideally I think we should save a JSON dictionary of the RC params with each figure to ensure reproducibility, and it's on my to-do list for pytest-mpl.

from astroplan.

Good point, indeed I have u'figure.figsize': [8.8, 6.6], set in rcParams.

from astroplan.

So what I have is with default setting for matplotlib 1.4.
So those tests would break when matplotlib 2.0 comes out soon with a new style.

@astrofrog – Defining our own plotting style for astroplan should be enough to keep these tests future-proof? (We plan to do this soon: #74) Or what's the recommended pattern to set this up in a robust way?

from astroplan.

Moving this to 0.2 ... it shouldn't block the 0.1 release which is long overdue.

from astroplan.

Pinging @astrofrog again to see if he has a solution to this issue.

from astroplan.

@bmorris3 - I have a solution, in my head, I just haven't had a chance to implement it yet ;)

Though actually for now, you can emulate this solution by resetting the rc parameters to the default at the start of the test:

plt.rcParams.clear()
plt.rcParams.update(plt.rcParamsDefault)

and be sure to re-generate the image.

from astroplan.

Marking Issue as stale and closing. Please re-open if still affected by this Issue.

from astroplan.