Comments (5)
So it looks like reviewing the code that we were missing the Lennarz reference max dates due to a typo in that section of the code. I'm taking this opportunity to also simplify our date format a bit, previously, we had four variables for each date: year, month, day, and date. The reason for this was that some events we might have only known the year or maybe the year and month; to specify this now we'll just omit that information from the date. I'll update this issue again once the changes go live.
Some questions about convention: Should we always use the V-band to specify max date if for a given event it is not specified? If we want to use V-band, what should we do when V-band is not available? Or should we use the brightest photometric point across all bands?
I'm leaning towards doing some sort of basic fitting to determine the peak magnitudes if they are not provided in a reference, this doesn't have to be bulletproof but it will do better than using the brightest point, which is ambiguous in many cases.
from astrocats.
re: convention questions.
Generally folks have quoted maximum light wrt B-band, V-band, or peak bolometric luminosity, when available. So long as it is specified, users of the Open Supernova Catalog will understand. Usually the difference between B-band and V-band maximum is a couple of days, and most studies that look to take a slice in epochs apply a window of +/- 3-5 days to skirt such issues. Once I am done scouting redshift corrections, next on the list will be rummaging through dates of maximum.
As for the fitting, agreed, it would provide at least a basic reference point (+/- 1-3 days).
from astrocats.
@guillochon Was going to close this one, but date of maximum for 11fe needs to be changed from Sept 6 2011 to Sept 10. I can do this one by hand unless you would like to scriptify.
from astrocats.
Had literally just updated SN2011fe with the script, check it now.
We're now using B band (and B-like bands) preferentially for the max date, followed by V band (or V-like bands), then R band (or R-like bands). If none of those bands are available then it just uses the maximum based upon all bands. The band used to determine the max is now denoted after the magnitudes are listed.
from astrocats.
Hah. All done!
from astrocats.
Related Issues (20)
- Can't use --depth command anymore? HOT 2
- Photometry: 'u_time': MJD is being added as default even to 'host' entries without time value HOT 2
- Move git-related `supernovae` scripts to `catalog` methods.
- Separate `PATHS` class from `Catalog`, and combine with `git-` methods. HOT 1
- Get 'update' mode working again HOT 2
- The path to v1.0
- Improve logging levels and logging file
- How can I use this? HOT 13
- Logger output conflicts with tqdm
- iframe doesn't resize when entry is opened in background tab
- Replace `future` with `six` HOT 2
- Combine `Entry._init_cat_dict()` and `Entry._add_cat_dict()`
- Entry.sanitize() fails (at times) with photometry that dont have `TIME` values.
- Add setting to determine warning/logging/error level when adding data fails
- Cleanup and improve PHOTOMETRY.TIME parameter HOT 3
- Consider using astroquery for image cutouts
- Importing the example catalogue [supernovae] results in error RuntimeError: Return value should have been None! HOT 2
- astrocats cannot import catalogs when installed with Anaconda HOT 3
- Failed OSC update HOT 2
- api.astrocats.space certificate expired HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from astrocats.