Giter Club home page Giter Club logo

Comments (6)

assuncaocharles avatar assuncaocharles commented on June 15, 2024

Hi @EndarValuk ,

Please, post more details when you can.

from ngx-indexed-db.

MattBorkowski avatar MattBorkowski commented on June 15, 2024

I took a look into this issue and it seems like with version 2.2.5 on the update function we are using an optional parameter for the key but aren't safe checking the objectStore.put function if that key is undefined. Simply removing the key param allows the update operations to work for IE and Edge.

Screen Shot 2019-12-20 at 10 06 14 AM

I propose we add a simple if statement to the put to keep support for IE and edge

if(key){
 objectStore.put(value, key);
} else {
objectStore.put(value);
}

from ngx-indexed-db.

assuncaocharles avatar assuncaocharles commented on June 15, 2024

Hi @MattBorkowski

Can you open a PR with your suggestion?

from ngx-indexed-db.

MattBorkowski avatar MattBorkowski commented on June 15, 2024

I sent in a PR, take a look whenever you have time. Hopefully this can help others that are running into the issue as well. Might be worth documenting these issues in a FAQ section.

from ngx-indexed-db.

assuncaocharles avatar assuncaocharles commented on June 15, 2024

Thanks @MattBorkowski

from ngx-indexed-db.

assuncaocharles avatar assuncaocharles commented on June 15, 2024

@EndarValuk can you try it on IE with the new version 3.0.13 and see if it works?

from ngx-indexed-db.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.