Giter Club home page Giter Club logo

Comments (8)

ds5678 avatar ds5678 commented on June 2, 2024

cc: @FACS01-01

from assetripper.

FACS01-01 avatar FACS01-01 commented on June 2, 2024

Do you have the original .anim files so I can test it? or AssetBundles
If you send them, also tell me the name of that first AnimationClip
By original .anim files I mean files made by yourself in Editor, not ripped files

from assetripper.

GZHYBFHHJ avatar GZHYBFHHJ commented on June 2, 2024

@FACS01-01 Here are the assets files of them
assets_files.zip

from assetripper.

GZHYBFHHJ avatar GZHYBFHHJ commented on June 2, 2024

NaN bug is fixed in #1321. I'm not sure if the second bug can be fixed (it still happens).
also, the animation recovery does not work with Unity version changing (target version: 2017.3.0f1). It throws an exception:

System.ArgumentException: Binding with index 6 hasn't been found (Parameter 'index')
         at AssetRipper.Processing.AnimationClips.AnimationClipConverter.GetBinding(Int32 index) in /home/gzhybfhhj/Programs/AssetRipperGithub/AssetRipper/Source/AssetRipper.Processing/AnimationClips/AnimationClipConverter.cs:line 567
         at AssetRipper.Processing.AnimationClips.AnimationClipConverter.ProcessConstant(IConstantClip constant, Int32 preConstantCurves, Single lastFrame) in /home/gzhybfhhj/Programs/AssetRipperGithub/AssetRipper/Source/AssetRipper.Processing/AnimationClips/AnimationClipConverter.cs:line 209
         at AssetRipper.Processing.AnimationClips.AnimationClipConverter.ProcessInner() in /home/gzhybfhhj/Programs/AssetRipperGithub/AssetRipper/Source/AssetRipper.Processing/AnimationClips/AnimationClipConverter.cs:line 68
         at AssetRipper.Processing.AnimationClips.AnimationClipConverter.Process(IAnimationClip clip, PathChecksumCache checksumCache) in /home/gzhybfhhj/Programs/AssetRipperGithub/AssetRipper/Source/AssetRipper.Processing/AnimationClips/AnimationClipConverter.cs:line 49
         at AssetRipper.Processing.Editor.EditorFormatProcessor.Convert(IUnityObjectBase asset) in /home/gzhybfhhj/Programs/AssetRipperGithub/AssetRipper/Source/AssetRipper.Processing/Editor/EditorFormatProcessor.cs:line 112
         at AssetRipper.Processing.Editor.EditorFormatProcessor.Process(GameData gameData) in /home/gzhybfhhj/Programs/AssetRipperGithub/AssetRipper/Source/AssetRipper.Processing/Editor/EditorFormatProcessor.cs:line 76
         at AssetRipper.Export.UnityProjects.ExportHandler.Process(GameData gameData) in /home/gzhybfhhj/Programs/AssetRipperGithub/AssetRipper/Source/AssetRipper.Export.UnityProjects/ExportHandler.cs:line 53
         at AssetRipper.Export.UnityProjects.ExportHandler.LoadAndProcess(IReadOnlyList`1 paths) in /home/gzhybfhhj/Programs/AssetRipperGithub/AssetRipper/Source/AssetRipper.Export.UnityProjects/ExportHandler.cs:line 128
         at AssetRipper.GUI.Web.GameFileLoader.LoadAndProcess(IReadOnlyList`1 paths) in /home/gzhybfhhj/Programs/AssetRipperGithub/AssetRipper/Source/AssetRipper.GUI.Web/GameFileLoader.cs:line 47
         at AssetRipper.GUI.Web.Pages.Commands.LoadFolder.AssetRipper.GUI.Web.Pages.ICommand.Execute(HttpRequest request) in /home/gzhybfhhj/Programs/AssetRipperGithub/AssetRipper/Source/AssetRipper.GUI.Web/Pages/Commands.cs:line 61
         at AssetRipper.GUI.Web.Pages.Commands.HandleCommand[T](HttpContext context) in /home/gzhybfhhj/Programs/AssetRipperGithub/AssetRipper/Source/AssetRipper.GUI.Web/Pages/Commands.cs:line 102
         at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context)

from assetripper.

ds5678 avatar ds5678 commented on June 2, 2024

Version changing is extremely experimental and will likely never be compatible with animation recovery.

from assetripper.

ds5678 avatar ds5678 commented on June 2, 2024

Are there any remaining errors blocking the closure of this issue?

from assetripper.

GZHYBFHHJ avatar GZHYBFHHJ commented on June 2, 2024

All bugs are fixed! Thanks

Also, I have a question about AnimationClip root motion curves. m_HasGenericRootTransform and m_GenerateMotionCurves exist in initial export of 5.5.1 AnimationClips, but seems that they are always zero. And in Unity 2017 Editor, generate root motion curves button shows in them.

from assetripper.

ds5678 avatar ds5678 commented on June 2, 2024

I'm not at home, so I can't check, but they might be editor only fields. If they are, then there is nothing stored for those fields in the game data.

from assetripper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.