Comments (12)
I would just test this manually by running this rule on packages with and without the commit hash.
from buildtools.
Yeah run it on some packages built on a recent Coherence-Signed, and it should pass (include both regular and .Sources packages). Then run it on older Coherence-Signed packages and it should fail.
from buildtools.
Yes. For example take a look at AssemblyHasCompanyAttributeRule
from buildtools.
Just a note on this one: the source packages (packages that don't have binaries in them) don't have commit hashes. The rule needs to take that into account and verify that there's no source file in the package (*.generated.cs
) that contains that attribute.
from buildtools.
Hmm could we have a convention in the rule that ignores *.Sources
packages? I don't like the idea of using *.generated.cs
as a flag because there could be other files that match that pattern.
from buildtools.
What's the best way to test this?
from buildtools.
I would ignore .Sources
packages and check everything else.
from buildtools.
Unzip the nupkg and check that the assemblies inside have the attribute set and its value matches the format of a commit hash. It would be too hard to verify that the actual value is the right commit.
from buildtools.
Oh, you mean the sources packages or how to test the attribute? 😕
from buildtools.
Ignoring .Sources
should be easy. We have access to the package id in the rule.
from buildtools.
Yeah of course we can't check that the hash is actually correct - we just want to verify existence.
from buildtools.
I was asking what the best way to set this up to test that my changes work is since there's no tests and I can't find where it's used anywhere.
from buildtools.
Related Issues (20)
- Consider removing `vmImage` from official builds HOT 1
- Turn on Component Governance in 2.1
- Convert to 1ES pipelines (2.1) HOT 1
- Check in the global.json file, use this to control SDK versions HOT 3
- Race condition when calling dotnet-install.ps1/sh twice in parallel threads HOT 1
- VSTS Templates: Publish Build Artifacts even on failed build HOT 3
- Internal.AspNetCore.Sdk overwrites core NuSpec attributes even when already specified HOT 2
- Add a java requirement to korebuild.schema HOT 2
- Test console output is packed with successful test run information HOT 8
- ApiCheck should ignore references to internal interfaces when diffing HOT 1
- PR against dotnet/cli to make dotnet-install scripts match HOT 3
- Update dotnet/cli with dotnet-install lock file work HOT 1
- NPV TCLogger writes non-existent status
- dotnet-install.sh lockfile is not guaranteed
- `Sdk_GenerateResxDesignerFiles` task applied to all resources HOT 1
- ApiCheck: Members relocated higher up in the hierarchy tree should not be marked as breaking changes HOT 2
- NuGetPackageVerifier should support wildcards HOT 6
- SignTool fails in VSTS and Jenkins, but not TeamCity HOT 12
- Update SDK to 3.0 Preview 1 HOT 1
- Default branch will be renamed to main
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buildtools.