Giter Club home page Giter Club logo

Comments (2)

petehalverson avatar petehalverson commented on August 16, 2024

Thank you @fresswolf ! So glad you caught this!

While the October CMS codebase in the image was matching that of the build tag, composer dependencies were not.

I don't recall my reasoning for removing it in the past, but I restored a part of the build process that matches build dependencies to the tag.

The automated build checks out and has been published to the Docker Hub.

Retry it locally, but be sure to pull the new image:

$ docker pull aspendigital/octobercms:build.455-php7.1-apache
$ docker run --rm aspendigital/octobercms:build.455-php7.1-apache composer info | grep october

october/backend                   v1.0.455           Backend module f...
october/cms                       v1.0.455           CMS module for O...
october/rain                      v1.0.455           October Rain Lib...
october/system                    v1.0.455           System module fo...

We should compare the composer info results to the tag as part of the automated build tests. At the moment, I only report it for reference.

from docker-octobercms.

fresswolf avatar fresswolf commented on August 16, 2024

Thank you for the quick fix. I agree that a test would help, as the way the october repo is tagged is a bit misleading (The tags are more or less useless when using composer)

from docker-octobercms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.