Conflicting files in copy_file_action about bazel-lib HOT 8 CLOSED

@purkhusid I cut a release with the fix: https://github.com/aspect-build/bazel-lib/releases/tag/v1.11.0. Closing for now, but you can reopen if the problem persists.

from bazel-lib.

This sounds familiar and may have been fixed in 80603fb. Do you want to try updating to the latest release, 1.10.1?

https://github.com/aspect-build/bazel-lib/releases/tag/v1.10.1

from bazel-lib.

@kormide I'm using the latest release. It seems like the fix fixes copy_to_bin but breaks copy_file_action in my case.
The change also doesn't make sense to me because by removing the label from the bat file name I would think that it would be more likely that the actions that create the bat output would collide.

from bazel-lib.

The change was made to support this case on Windows.

copy_to_bin(
    name = "a",
    srcs = [
        "file"
    ]
)

copy_to_bin(
    name = "b",
    srcs = [
        "file"
    ]
)

If the labels are different then two different scripts were created which declare the the same file as an output, so bazel complains about conflicting actions. After the fix, the targets create an identical script that outputs the copied file, which bazel is okay with.

Can you paste the error you're seeing or push a branch so that I can investigate further?

from bazel-lib.

Ah, the issue I have is that Bazel complains that there are 2 different targets that output the same script file. So it's not the outputs of the copy action that conflict but the script files. I'll paste the error when I'm back at the computer.

from bazel-lib.

https://github.com/purkhusid/rules_dotnet/blob/695ffff8b2dd4f4aae30372f0f3e094be52721dc/examples/publish_binary/BUILD#L21

In the example you linked to, are those two targets supposed to produce two different output files with the same content, or the same output file?

If it's the former, maybe what I need to do here is name the script after a hash of the source and the destination file, rather than just the source.

from bazel-lib.

I got a PR up that hopefully fixes your case: #221

from bazel-lib.

https://github.com/purkhusid/rules_dotnet/blob/695ffff8b2dd4f4aae30372f0f3e094be52721dc/examples/publish_binary/BUILD#L21

In the example you linked to, are those two targets supposed to produce two different output files with the same content, or the same output file?

If it's the former, maybe what I need to do here is name the script after a hash of the source and the destination file, rather than just the source.

Yes, that is the case. The error is:

ERROR: file 'publish_binary/478990217-cmd.bat' is generated by these conflicting actions:
Label: //publish_binary:publish_self_contained, //publish_binary:publish_not_self_contained
RuleClass: publish_binary_wrapper rule
Configuration: 2d025b54d1e798337c54da69c5ab51e6e250f93e5d6a812a4f1f0030d6869a75
Mnemonic: FileWrite
Action key: 596af37dc0561a5711b4554c15126ceef0006a085d8edc0916527b0584c6261d, 56060fef44722e1300d9738701c7d20e85b09abd07340c2b7d9f42b478638ea2
Progress message: Writing script publish_binary/478990217-cmd.bat
PrimaryInput: (null)
PrimaryOutput: File:[[<execution_root>]bazel-out/x64_windows-fastbuild/bin]publish_binary/478990217-cmd.bat
Owner information: ConfiguredTargetKey{label=//publish_binary:publish_self_contained, config=BuildConfigurationValue.Key[2d025b54d1e798337c54da69c5ab51e6e250f93e5d6a812a4f1f0030d6869a75]}, ConfiguredTargetKey{label=//publish_binary:publish_not_self_contained, config=BuildConfigurationValue.Key[2d025b54d1e798337c54da69c5ab51e6e250f93e5d6a812a4f1f0030d6869a75]}       
MandatoryInputs: are equal
Outputs: are equal

I'll test the fix when I get the time but it looks like it should fix it.

from bazel-lib.