When updating relationships, if records are passed in, we shouldn't read them back about ash HOT 4 CLOSED

Right now there are no examples. We first need to update the changeset code to accept instances of a resource (and not just take the primary key of changes), e.g: https://github.com/ash-project/ash/blob/master/lib/ash/changeset/changeset.ex#L340.

Probably a good way to do it would just be to make this function: https://github.com/ash-project/ash/blob/master/lib/ash/changeset/changeset.ex#L605 put the actual related record as context on the struct (using Ash.Changeset.put_context()), and then in the read requests in Ash.Actions.Relationships, you can use those values instead of running a query. Keep in mind that it may be mixed input, like [%{id: 1}, %RelatedThing{...}].

In retrospect, this may not be a great first issue, but its a really good one to tackle!

from ash.

Can you please provide an example of passing structs instead of {id, %Ash.Changeset{}}, I could not find any.

from ash.

in case of mixed input [%{id: 1}, %RelatedThing{...}], PR: #135 checks if all inputs are valid entities or not. if one of them is not a valid resource, it lets the read query do his work normally. there will be no gain in passing other entities, as we will be hitting database anyway

from ash.

@kingshalaby1 perfect 👍

from ash.