DB.Save() panics if struct with embedded struct is passed by value about storm HOT 8 CLOSED

Sorry, i does not fail for me either but this fails:

package main

import (
    "log"
    "time"

    "github.com/asdine/storm"
)

type User struct {
    ID          int    `storm:"id"`
    Name        string `storm:"index"`
    age         int
    DateOfBirth time.Time `storm:"index"`
    Group       string
    Slug        string `storm:"unique"`
}

func main() {
    db, err := storm.Open("my.db", storm.AutoIncrement())
    if err != nil {
        log.Fatal("db open:", err)
    }
    defer db.Close()

    user := User{Name: "John"}

    if err = db.Save(user); err != nil {
        log.Fatal("save user: ", err)
    }
}

The AutoIncrement option makes it fail because Storm needs to access the ID field to set the new incremented value

from storm.

Indeed, any required access to a non-addressable field would do.

(The previous example without the AutoIncrement option failed because the ID==0 which is different than the field not being addressable)

from storm.

I can reproduce it with a simple struct passed by value. The question is should we only accept pointers to structs or also accept copies?

from storm.

Could you please post an example of a simple struct passed by value that fails? I tried one without any inline tags and it worked.

I think supporting just pointers is fine, for efficiency callers would want to use pointers anyway instead of making copies of potentially large structs.

from storm.

Here is one:

w := User{Name: "John"}
err := db.Save(w)
assert.Error(t, err)
assert.Equal(t, ErrStructPtrNeeded, err)

from storm.

What is the struct definition of User in your example above? Just like the one in my bug report above?

from storm.

It is a simple struct that you can find here and that i use for several tests

from storm.

Thanks for the fix. Interesting that I can't get it to fail with your simple User struct.

Here's what I tried before the fix and it worked fine for me. It worries me if it failed for you but not for me.

package main

import (
    "log"
    "time"

    "github.com/asdine/storm"
)

type User struct {
    ID          int    `storm:"id"`
    Name        string `storm:"index"`
    age         int
    DateOfBirth time.Time `storm:"index"`
    Group       string
    Slug        string `storm:"unique"`
}

func main() {
    db, err := storm.Open("my.db")
    if err != nil {
        log.Fatal("db open:", err)
    }
    defer db.Close()

    user := User{ID: 20, Name: "John"}

    if err = db.Save(user); err != nil {
        log.Fatal("save user: ", err)
    }
}

from storm.