Giter Club home page Giter Club logo

Comments (6)

jthegedus avatar jthegedus commented on May 24, 2024 4

I am going to close this now. I like some of the suggestions in this thread, but the root cause of this issue are no longer present.

from asdf-plugins.

Stratus3D avatar Stratus3D commented on May 24, 2024 3

My suggestion would be to leave things as is. BUT... maybe we can build a bot that will automatically open up an issue (or someone does this manually as cleanup) and simply does a "@username your plugin 'blah-blahblah' is marked as a failing plugin. This is a courtesy comment to inform you that your plugin will be automatically removed if it has not passed a build in the next 30 days. Thank you."

Yes! This is what I'd like to have. If a plugin is failing but the maintainer is responsive and gets it fixed within a certain window of time I don't think it should be removed. I like the idea of a bot a lot, but it seems like it would be a lot of work, and I'm not even sure where to begin.

from asdf-plugins.

particledecay avatar particledecay commented on May 24, 2024

I found this issue because I was about to open one saying the exact same thing. I just created two PRs to add plugins, and the PRs both failed builds because of plugins entirely outside of my control... that means that until ALL plugins are fixed, NO pull requests will pass tests. That seems ridiculous.

I like the idea of filtering list-all somehow with only passing plugins, however... if you look at how long the bash test.sh takes to run, you'll see this is pretty prohibitive (we'd send a new request for every official plugin every time we run that command) as it will take forever.

My suggestion would be to leave things as is. BUT... maybe we can build a bot that will automatically open up an issue (or someone does this manually as cleanup) and simply does a "@username your plugin 'blah-blahblah' is marked as a failing plugin. This is a courtesy comment to inform you that your plugin will be automatically removed if it has not passed a build in the next 30 days. Thank you."

We have all the information we need to notify the owners, and give them a chance to fix. If they don't fix within 30 days, maybe we can consider the plugin abandoned and it should be removed.

from asdf-plugins.

canterberry avatar canterberry commented on May 24, 2024

👆 Sounds like a good candidate for organizing w/Github Projects. It seems totally within the scope of this repo to have something like that, and it would be involve several moving pieces. In the meantime, someone... looks around... could design, propose, and run the process manually. 👀

from asdf-plugins.

Stratus3D avatar Stratus3D commented on May 24, 2024

@imbsky what do you think of all this?

from asdf-plugins.

mwgamble avatar mwgamble commented on May 24, 2024

Is this issue even still relevant? It looks like Github actions is in use, although the readme still references Travis.

from asdf-plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.