no PR merged since mid-December about asdf-plugins HOT 8 CLOSED

A search for a specific term within the "asdf-plugin" topic is done using this URL by the way:

https://github.com/search?q=%23asdf-plugin+SEARCH_TERM&type=Repositories

from asdf-plugins.

Hi all, I was the member of the core managing PRs here. I have been on holidays followed by an intense workload so haven't contributed any open source since mid December. As @Stratus3D says, we want to move away from this repo in the future, so encourage everyone to use the asdf plugin add <name> <git_url> method (even the readme shows this) instead as it does not rely on this repo or the asdf core team to get plugins into your hands.

Closing this PR as I am back actively contributing to open source, however I encourage everyone to use the asdf plugin add <name> <git_url> method as it allows you to use plugins from anywhere without this centralised repo.

Note: we will still accept PRs to this repo to help discovery of plugins and support the current model, we are just trying to signal future intent, not that anything is currently deprecated.

from asdf-plugins.

@Stratus3D maybe you can shed some light onto this situation? 🙏🏻

from asdf-plugins.

Yes. I've not been a fan of this repository from the beginning. I've got some comments on asdf-core that explained this a while back, but I can't find them. There are a couple problems with it:

• Because it's part of the asdf-vm Github org, some users get confused and equate the plugin list as some sort of vetted list of plugins. There is no process for validating plugins listed in this repo, and plugins may break at any time.
• Users may create PRs, but as you've seen a maintainer must review and merge them. We don't have any maintainer time to spare on this repo as asdf-core takes all of our time. Hence the current state of the repo.

I've not really spent any time on this repo because I'm busy with work on asdf-core. I don't plan on changing this and would like to archive this repo eventually. Ideally we'd have a website somewhere that would allow users to list plugins they've created, search and upvote them in an intelligent way, similar to Github and Dockerhub. One possible low-effort solution to this would be to use Github topics search - https://github.com/topics/asdf-plugin. A saved Github search for any repo with the topic asdf-plugin and the name of the tool you'd like to version may be enough to solve this for 99% of use cases.

from asdf-plugins.

Thanks for clarifying the state of affairs! I like the idea of a topic search that can be linked from the asdf website. One caveat of archiving this repo would be that from then on users don't have a way of distributing their plugin using only asdf plugin add my-plugin, anymore. Maybe that workflow should be constrained to core plugins from then on?! This would certainly be a breaking change, though.

from asdf-plugins.

Yes, so possible solutions to breaking asdf plugin add would be to archive this repo so it's read-only going forward and allow the current syntax to be used for a year or so after deprecation so users have time to transition. We'd also introduce a syntax for adding Github repos as well. For example, we could allow a shorthand of something like this:

asdf plugin add asdf-community/asdf-php

and that would clone down the latest from https://github.com/asdf-community/asdf-php. It almost mirrors what you see in Dockerfiles.

from asdf-plugins.

That all sounds fair, especially given that it frees up your time to work on core. 🙂

from asdf-plugins.

Is there a corresponding issue for the suggested future implementation in the core repository and/or is it being worked on?

from asdf-plugins.