list-all GitHub releases on OSX fails about asdf-plugins HOT 10 CLOSED

hm, your script is working on my mac. :/

from asdf-plugins.

Thanks @vic

Looks like I am missing the new lines in list-all on osx, but the travis job should pass.

Here's the trafis config:

language: c
before_script:
  - git clone https://github.com/asdf-vm/asdf.git
  - . asdf/asdf.sh
script: 
  - asdf plugin-add terragrunt ./
  - asdf list-all terragrunt
  - asdf plugin-test terragrunt ./ 'terragrunt --version'
os:
  - osx

Which is the same as this passing asdf plugin: https://travis-ci.org/td7x/asdf-adr-tools

from asdf-plugins.

@tomdavidson I'm not sure. Is there a specific error you get? I looked at the failing build and it's unclear what caused the list-all command to fail. Which command fails? curl, grep, or one of the sed commands?

from asdf-plugins.

I tested the code on my machine (OSX 10.13.3) and it works.

from asdf-plugins.

Does the asdf test runner have a debug flag? All I have is :

The command "asdf list-all terragrunt" exited with 0.
1.26s$ asdf plugin-test terragrunt ./ 'terragrunt --version'
Cloning into '/var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/asdf.XXXX.MskuXBED'...
remote: Counting objects: 2994, done.
remote: Compressing objects: 100% (18/18), done.
remote: Total 2994 (delta 14), reused 29 (delta 13), pack-reused 2962
Receiving objects: 100% (2994/2994), 465.91 KiB | 5.48 MiB/s, done.
Resolving deltas: 100% (1580/1580), done.
Cloning into '/var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/asdf.XXXX.MskuXBED/plugins/terragrunt'...
done.
FAILED: list-all did not return any version
The command "asdf plugin-test terragrunt ./ 'terragrunt --version'" exited with 1

The list-all code is in the op. works on vic's osx and in the asdf-adr-tools travis build. @vic do you have gnu-tools installed?

from asdf-plugins.

asdf list-all terragrunt or invoking the script directly works fine, its asdf plugin-test ... where the error occurs. Could this be a bug with plugin-test? Any direction on debugging?

from asdf-plugins.

@tomdavidson we do not. We should though. Do you want to open an issue or PR on the asdf repository?

from asdf-plugins.

Thanks @Stratus3D I dont have a code change to propose so Ill open an issue on asdf.

from asdf-plugins.

You all might hate me but this is significantly more straightforward if you require jq. I know that adds a dependency... but at least jq behavior is cross-platform and predictable, and we're already working with JSON if we're requesting from GitHub's API.

One of the plugins I submitted in #128 actually has different release files per platform (sometimes). So I can't just assume ".tar.gz". It was much more straightforward to use jq:

curl -s https://api.github.com/repos/$repository/releases |\
jq -r --arg version "$version" --arg arch "$arch" \
'.[] | select(.tag_name==$version).assets[] | select((.name | contains($arch + "-amd64")) and ((.browser_download_url | endswith(".tar.gz")) or (.browser_download_url | endswith(".zip")))).browser_download_url'

Worked on mac and linux.

from asdf-plugins.

@tomdavidson are you aware of any other plugins having this issue? I think we can close this issue as tests for the plugin-test command have been added.

from asdf-plugins.