Giter Club home page Giter Club logo

Comments (4)

mdboom avatar mdboom commented on June 20, 2024

You can use a with block, but it needs to be active as long as you need access to the data. (The data is memmapped and the memmap handles are closed at the same time as the file handle). You can also use an explicit close if that's easier.

from asdf.

nden avatar nden commented on June 20, 2024

Right. I knew that. Sorry about the noise.

from asdf.

embray avatar embray commented on June 20, 2024

I think there should still be more control over this kind of thing. PyFITS deliberately leaves the mmaps open because it's an implementation detail which most users won't even tend to understand, and not allowing this to work I think discourages use of the with statement by users in many cases (for read-only applications it doesn't matter, but there are plenty of write applications where it would be good to use with).

Of course, PyFITS has the opposite problem where users think they've closed the file but they really haven't. I think both should have some way to control this better (but I lean toward leaning mmaps open except when the user has explicitly requested to close them as well).

from asdf.

mdboom avatar mdboom commented on June 20, 2024

Yeah -- there's sort of no perfect option here. A kwarg to indicate whether to close the mmaps automatically might be helpful, though.

from asdf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.