Some features to analyse 2D wall loads about ascot5 HOT 4 OPEN

Currently implemented so that the runmixin methods of calculating heat loads work for also 2D wall. However, currently the incident angle will not work(will not return anything meaningful), since for 2D wall the incident angle is determined in only R and z (and phi would be determined on the collision point of the marker, but that is not currently used for 3D detection).

Therefore, iangle for 2D walls will not currently result in anything meaningful. Should the code say something of this to the user, or what is your opinion @miekkasarki ?

from ascot5.

What do you mean "for 2D wall the incident angle is determined in only R and z"? Isn't there a sufficient information to calculate the angle in post-processing?

I think the easiest way to have all features of the 3D wall available for 2D wall is to assume that the 2D wall is 3D where each element is a stripe that revolves around the whole torus. That way you get the area and surface normal (which now depends on phi) which are sufficient to calculate any quantity of interest.

from ascot5.

What I mean by that is that I did not modify the runmixin method of calculating heat loads. The runmixin only needed to call wall.area(). I implemented that area method for 2D walls. However, the heatload method also wants surface normals of the walls (which are undefined for the 2D walls due to phi), so currently the iangle does not work with the method. Moreover, I am not certain of the usefulness of that metric for 2D walls. (If you are certain it is useful, I can modify the runmixin heatload method to get the correct normals for 2D walls. The reason I originally did not do it is because the method is getting too large/convoluted.)

My question to you was, (assuming no modification to the heatload code) should I give a note that the 2D incident angle is not defined.

from ascot5.

Well it could be useful, but for now it is sufficient that the docstring states that iangle is not calculated for 2D walls.

from ascot5.