Comments (4)
mojavelinux
commented on June 14, 2024
We do need to set a base URL for images because the preview pane is just a div inside main Atom window and it's base URL is the Atom install directory. Thus, images aren't going to resolve if they are relative.
We could set imagesdir to the basedir value that we define. However, if the document defines a different relative imagesdir, then it either won't get updated or it won't be set correctly. I think we're going to need a setting in Asciidoctor.js that allows us to set a base URL that is prepended to all web assets. Perhaps just call it baseurl. Experimentation required.
from atom-asciidoc-preview.
mojavelinux
commented on June 14, 2024
Clearly, the post-processing image code is serving a purpose. I just think we could do it better by putting it in the processor itself. Post-processing the HTML feels like a hack.
from atom-asciidoc-preview.
nerk
commented on June 14, 2024
The same issue exists for the Brackets preview. Unfortunately, I really don't have a good idea regarding this issue either. :-(
from atom-asciidoc-preview.
mojavelinux
commented on June 14, 2024
This may require changes to Asciidoctor core to accommodate these scenario better. I'll be revisiting it for Asciidoctor 1.5.0 or shortly after and will advise as I have more info.
from atom-asciidoc-preview.
Related Issues (20)
- Save as HTML does nothing (~/.atom/packages/asciidoc-preview/node_modules/asciidoctor.js/dist/css/asciidoctor.css not found) HOT 2
- Unable to see images in project with Antora folder structure HOT 4
- The foldable details summary div doesn't work HOT 5
- Live Preview is not Antora compatible
- How to open the preview in a separate window or tab? HOT 1
- How to display blockdiag in asciidoc preview?
- How to display stem content in asciidoc preview HOT 3
- no Preview, only "Loading AsciiDoc..." HOT 1
- Live preview doesn't work for some languages
- Uncaught TypeError: s.nodeName.toLowerCase is not a function HOT 1
- Asciidoc preview does not load in Atom HOT 2
- plantuml mindmap leveloffset to include subnodes
- The option 'nowrap' is not supported
- The source tag does not preview properly when using the specified language,such as Java or Python
- CSS customization in README
- Specifying custom css file HOT 1
- Code blocks blank in preview. HOT 5
- HTMLDocument.registerElement is deprecated. HOT 1
- Preview of Asciidoc File Shows Blank in Atom. HOT 1
- Recommend alternatives and archive this project
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from atom-asciidoc-preview.