Comments (2)
Good idea!
I also think that it would be good to "slim" down our dependencies.
Although I hate to say it I would be fine with dropping Arquillian.
The only reason should be the amount of work :)
But if we can migrate gradually then I think the task would be far less intimidating.
from asciidoctorj.
Although I hate to say it I would be fine with dropping Arquillian.
Me too, it's not only part of the project but of the contributors. But in the end, even if we could keep it using the RC versions, using a JUnit extension means fewer dependencies and a framework more supported. And it's easier for contributors too. I see really no advantages in Arquillian.
So far I have been able to remove Arquillian from some tests adding a few lines to init Asciidoctor and the classpath tools.
That's the part we can refactor to reduce boilerplate, but it's not a big complexity.
But if we can migrate gradually then I think the task would be far less intimidating.
The current PR aims for that, but there's the issue of Spock compatibility, newer versions have removed org.spockframework.runtime.Sputnik
which org.jboss.arquillian.spock.ArquillianSputnik
uses, so I've been forced to remove Arquillian wherever we had @RunWith(ArquillianSputnik)
😞 .
That's maybe the biggest re-write so far.
PS: btw, org.junit-pioneer:junit-pioneer
does not pull any third-party lib which is nice.
from asciidoctorj.
Related Issues (20)
- Integrate 'Coordinated Restore at Checkpoint' HOT 5
- Remove deprecated methods from Options and Attributes HOT 3
- Remove deprecated methods from Asciidoctor interface
- Remove deprecated methods from Document interface
- Remove deprecated methods from `extension` package
- Remove deprecated methods from `ast` package HOT 3
- included jruby version is vulnerable due to snakeyaml dependency HOT 3
- release 3.0.0-alpha.1 is gravely incompatible with earlier releases HOT 11
- 'UnsupportedOperationException' when passing immutable Map as options to 'createPhraseNode' HOT 1
- Use always latest versions in distribution HOT 3
- Ensure AsciidoctorJ version is returned always in CLI
- exception containing itself as nested exception, causing maven endless loop HOT 7
- feature request: render asciidoc to markdown HOT 3
- -s CLI option should be changed to -e to align with Asciidoctor
- Automatic-Module-Name is undefined in MANIFEST file HOT 4
- CLI should set :mkdirs option by default HOT 7
- Custom Macro HOT 1
- setContext not exposed in API HOT 1
- Include processor with all attributes resolution HOT 2
- highlight.js version 9 used by AsciiDoctorJ needs update as it is out of support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from asciidoctorj.