Giter Club home page Giter Club logo

Comments (2)

robertpanzer avatar robertpanzer commented on May 26, 2024

Good idea!
I also think that it would be good to "slim" down our dependencies.
Although I hate to say it I would be fine with dropping Arquillian.

The only reason should be the amount of work :)
But if we can migrate gradually then I think the task would be far less intimidating.

from asciidoctorj.

abelsromero avatar abelsromero commented on May 26, 2024

Although I hate to say it I would be fine with dropping Arquillian.

Me too, it's not only part of the project but of the contributors. But in the end, even if we could keep it using the RC versions, using a JUnit extension means fewer dependencies and a framework more supported. And it's easier for contributors too. I see really no advantages in Arquillian.
So far I have been able to remove Arquillian from some tests adding a few lines to init Asciidoctor and the classpath tools.
That's the part we can refactor to reduce boilerplate, but it's not a big complexity.

But if we can migrate gradually then I think the task would be far less intimidating.

The current PR aims for that, but there's the issue of Spock compatibility, newer versions have removed org.spockframework.runtime.Sputnik which org.jboss.arquillian.spock.ArquillianSputnik uses, so I've been forced to remove Arquillian wherever we had @RunWith(ArquillianSputnik) 😞 .
That's maybe the biggest re-write so far.

PS: btw, org.junit-pioneer:junit-pioneer does not pull any third-party lib which is nice.

from asciidoctorj.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.