Giter Club home page Giter Club logo

Comments (4)

mojavelinux avatar mojavelinux commented on May 18, 2024

You are correct that this is an issue with this backend. We need to be checking which syntax highlighter is in use before adding the zenburn style to the HTML output.

from asciidoctor-reveal.js.

wackywendell avatar wackywendell commented on May 18, 2024

Well... I may be over my head, but I'm not sure its quite that simple. I tried just removing the <link href="[...]/zenburn.css"> line from the HTML output, and it still has that same color.

Looking at the Developer Tools > Inspector in Firefox lead me to this:

.reveal pre code {
  display: block;
  padding: 5px;
  overflow: auto;
  max-height: 400px;
  word-wrap: normal;
  background: #3F3F3F;
  color: #DCDCDC; }

Which comes from simple.css line 140.

It looks to me like the background and color attributes shouldn't be there (i.e., its a problem with reveal.js), or should be overridden when not using highlight.js. Overridden might make more sense, as that also covers "plain" code blocks where pygments / coderay wasn't run.

from asciidoctor-reveal.js.

mojavelinux avatar mojavelinux commented on May 18, 2024

should be overridden when not using highlight.js

Yes, this is the second part to the change. We have to do a lot of this in the default Asciidoctor stylesheet, so it's the same routine here.

from asciidoctor-reveal.js.

obilodeau avatar obilodeau commented on May 18, 2024

Is this still an issue? Can I get a more precise reproducible case with screenshots?

from asciidoctor-reveal.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.