Giter Club home page Giter Club logo

Comments (21)

jchasey avatar jchasey commented on June 12, 2024

In the meantime can support for custom component card be added?

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

hey @jchasey please log a seperate issue/ER for the custom component card.. I'll look at that after

Currently working on a separate branch MigrateToPipWiserApi where I plan to migrate the code to use pypi package and then eventually publish on ha website

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

Wiserhub code published to PyPi (#24) and https://pypi.org/project/wiser-heating-api/

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

Still working on it in UseNewPyPi branch. PLan is to get it working with the new component layout and use library in pypi then push it along

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

guys,

Im prepping the package for inclusion into Home Assistant. To this end Ive got he main wiserHub package now on PyPi and reformatting code etc so that it conforms to HA standards. Can someone please give it a whirl and see if its all ok?

its on dev branch "UseNewPyPi" so to get to it use

git clone [email protected]:asantaga/wiserHomeAssistantPlatform.git
git checkout 

The rest is the same as before

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

Partially done in R1.4.

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

if anyone wants to help, let me know.. Im a bit baffled at how to do the documentation
at the moment..

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

@michthom

Hey there, thanks for offering to assist here.
From what I know that needs doing

  • 1. Code reformatting to conform to HA Standards
  • 2. Documentation , havent quite worked out how that works with HA

Can u help here, especially with the latter?

from wiserhomeassistantplatform.

michthom avatar michthom commented on June 12, 2024
  • 1. Code reformatting to conform to HA Standards
  • 2. Documentation , havent quite worked out how that works with HA
    Can u help here, especially with the latter?

Hopefully my pull request #47 will help a bit with part 1, and as for part 2, I think I'd need a bit more context - your readme is pretty good already I think. What are you least happy with, and I'll take that as a starting point? Or is there an "expected" format / Wiki entry required as part of the HA submission? If there's a link to that drop a link in here and I'll do some reading.

[edit] Not to worry, I found this helpful page on the Dev wiki, so I'll clone the doc repo and mock up a new page for the Wiser stuff.

[edit2] I've created a fork of the homeassistant.io repo, and added a Wiser logo and an integration page. Let me know if you're happy with the wording so far?

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

thanks, I'll find some time soon to merge the PR and go through the coding standards things.. some are really archaine.. like no lines can be longer than 78characters....

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

[edit2] I've created a fork of the homeassistant.io repo, and added a Wiser logo and an integration page. Let me know if you're happy with the wording so far?

looks good..

from wiserhomeassistantplatform.

michthom avatar michthom commented on June 12, 2024

the coding standards things.. some are really archaine.. like no lines can be longer than 78characters....

When I ran the 'black' tool against your original code, I told it to shorten to no longer than 80 characters, but where did you see the 78 character restriction? I had a look here and here but didn't see that mentioned?

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

must have been an old thing, or I got mistaken... all good though.

from wiserhomeassistantplatform.

michthom avatar michthom commented on June 12, 2024

Hi Angelo. I got some help from @balloob on Discord with my confusion about the category pages not picking up the new documentation pages, but having saved a change to /source/integrations/index.html they did update, so I've incremented the release to 0.105 and updated my fork of the HA repo. I'm assuming you'd prefer to clone my repo and then create a pull request for HA to pull from you direct?

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

thanks Michthom, I'll do the merging this weekend...

I'm assuming you'd prefer to clone my repo and then create a pull request for HA to pull from you direct?

That would make sense, we need to tweak the main code a bit (I think) then we can submit it

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

@michthom ,

I didnt get to it this weekend but yes I'll clone your repo then create the HA PR from there.. Appreciate all the work youve done and credit will be where credit is deserved.

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

Ive paused this for a bit as we're (msp1974 ) has rewritten chunks of the code using async calls instead of sync calls. Need to test this, merge it in and then use black tool against his code (I dont think he started with the black tool PR)

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

@michthom , I'll clone your HA repo later today so we can at least get the docs stuff ready for when we finish the work msp1974 is doing.

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

R1.9 is nearly done, once this is done I'll work on this ticket..

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

will do this for 2.0

from wiserhomeassistantplatform.

asantaga avatar asantaga commented on June 12, 2024

Closing this one for now

from wiserhomeassistantplatform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.