Comments (4)
Can't reproduce this bug. If I give the command :
./SMSD -T SDF -t Data/arom.sdf -N -O MOL -o tmp.mol
then I get the subgraph in tmp.mol and Data/arom.sdf is still there.
from smsd.
Try these files
a) query git clone git://gist.github.com/934995.git gist-934995 (1.mol)
b) target git clone git://gist.github.com/934989.git gist-934989 (connected.sdf)
java -Xms500M -Xmx500M -cp SMSD20110421.jar cmd.SMSDcmd -Q MOL -q 1.mol -T SDF -t connected.sdf -N -r -g
The reported error is
Exception in thread "main" java.lang.NullPointerException
at org.openscience.reactionblast.graphics.direct.LabelManager.setUsedPosition(LabelManager.java:126)
at org.openscience.reactionblast.graphics.direct.DirectAtomDrawer.drawAtomID(DirectAtomDrawer.java:292)
at org.openscience.reactionblast.graphics.direct.DirectAtomDrawer.drawAtom(DirectAtomDrawer.java:131)
at org.openscience.reactionblast.graphics.direct.DirectAtomDrawer.drawAtoms(DirectAtomDrawer.java:92)
at org.openscience.reactionblast.graphics.direct.DirectMoleculeDrawer.drawMolecule(DirectMoleculeDrawer.java:116)
at org.openscience.reactionblast.graphics.direct.layout.ZoomToFitGridLayout.layout(ZoomToFitGridLayout.java:50)
at cmd.ImageGenerator.createImage(Unknown Source)
at cmd.ImageGenerator.createImage(Unknown Source)
at cmd.OutputHandler.writeImage(Unknown Source)
at cmd.SMSDcmd.runSingleQueryMultipleTarget(Unknown Source)
at cmd.SMSDcmd.run(Unknown Source)
at cmd.SMSDcmd.main(Unknown Source)
This is also followed by overwriting of the Target.mol.
from smsd.
Ok, so there are several separate issues here:
- The -Q/q options are not currently designed to be used with -N.
- The NPE in the graphics was already fixed, but had not been added.
- Overwriting the Target mol.
The second of these is now fixed in 75f8744 - in the sense that it no longer throws errors, but the underlying problem (label crowding) is more difficult.
The first problem is less clear : if this combination of arguments is valid, the N-MCS method in SMSDcmd will have to be re-written. If they are not meant to be used together, then perhaps SMSD should throw an error?
I'm not sure about the third problem. If the command was -Q MOL ... -T SDF, then each target in the sdf file is written out to a separate file. Also, a large number of images are created. Perhaps there should be separate issues for these?
from smsd.
Thanks Gilleain,
Yes we need to think about label crowding and rewriting the options, but presently SMSD should throw some kind of error in handling unsupported options.
from smsd.
Related Issues (12)
- SDF file matching output
- Image generation problems for N-MCS HOT 1
- Fragments HOT 2
- atom atom mapping index HOT 2
- restricted mapping of ring atoms and linkers HOT 1
- Could you release this via Maven HOT 1
- NullPointer: Aromaticity model
- MCS Code not working with CDK 2.x
- Use actual CDK dependencies, not cdk-bundle
- Is this project still active? HOT 1
- Update on maven central
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smsd.