Giter Club home page Giter Club logo

Comments (4)

ashfurrow avatar ashfurrow commented on July 23, 2024

This PR: artsy/eidolon#496

Ran the converter, which failed shortly after beginning.

Further ideas:

  • isEmpty could have a corresponding isNotEmpty. (Done)
  • OptionSets are cool πŸ‘
  • isEmpty should be able to be used on optional strings. (Done)
  • UITextField has optional text property.
  • No longer have to cast with objc generic arrays
  • FLKAutoLayout/our own libraries could use objc generic arrays
  • SSL thingy
  • Quick/Nimble update was painless 🌟 only change: https://github.com/artsy/eidolon/pull/496/files#diff-99681ae03e7455abb84f2358ea7ae5f2R9
  • As long as none of the Kiosk iPads are updated to iOS 9, we're fine.
  • Operator precedence in RAC macros.

from mobile.

modocache avatar modocache commented on July 23, 2024

Quick/Nimble update was painless 🌟

Great!! Feedback always appreciated on other sore spots, feature requests, etc.

from mobile.

ashfurrow avatar ashfurrow commented on July 23, 2024

πŸ™‡ Thanks Brian!

As for the isNotEmpty on (optional?) strings, the solution isn't that complex:

public protocol Occupiable {
    var isEmpty: Bool { get }
    var isNotEmpty: Bool { get }
}

public extension Occupiable {
    public var isNotEmpty: Bool {
        return !isEmpty
    }
}

extension String: Occupiable { }

public extension Optional where Wrapped: Occupiable {
    var isNilOrEmpty: Bool {
        return self?.isEmpty ?? false
    }

    var isNotNilNotEmpty: Bool {
        return !isNilOrEmpty
    }
}

I just don't know if this is a good idea. I mean, why not, eh? But it doesn't seem very idiomatic.

from mobile.

ashfurrow avatar ashfurrow commented on July 23, 2024

Also, need to remove public everywhere. We have @testable now.

from mobile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.