Giter Club home page Giter Club logo

Comments (5)

eatsjobs avatar eatsjobs commented on May 24, 2024 1

Up. Same problem with 3.6.1 version. Somenthing like that could work?

function normalizeURI (uri) {  
  return uri.replace(/(:\/\/)|(\\+|\/{2,})+/g, match => {
    if(match === '://' || match === '//') {
      return match;
    } else {
      return '/';
    }
  })
}

from webpack-pwa-manifest.

arthurbergmz avatar arthurbergmz commented on May 24, 2024

Protocol-relative URLs are now considered an anti-pattern, but I can't see the error on the second example.
Can you provide more information about your issue?

from webpack-pwa-manifest.

pfdgithub avatar pfdgithub commented on May 24, 2024

Protocol-relative URLs are now considered an anti-pattern

it's right, but it's convenient to use when switching multiple deployment environments.

but I can't see the error on the second example.

The second example there is no problem, it's just for comparison.

from webpack-pwa-manifest.

arthurbergmz avatar arthurbergmz commented on May 24, 2024

I'll take a look at it for the next release.

from webpack-pwa-manifest.

arthurbergmz avatar arthurbergmz commented on May 24, 2024

@eatsjobs

Hey, can you test it and make a PR, please?

from webpack-pwa-manifest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.