Giter Club home page Giter Club logo

Comments (25)

kentonh avatar kentonh commented on July 17, 2024 2

@toubou91 I've made a new PR that removes the need to edit _includes/head.html for your specific site implementation. Once merged, you should be able to update and all social graph and twitter card meta information will be determined via Jekyll's _config.yml file

from flexible-jekyll.

kentonh avatar kentonh commented on July 17, 2024 1

This should probably be done through Twitter cards and if that's being added, it might be good to add Facebook Open Graph data

from flexible-jekyll.

teobais avatar teobais commented on July 17, 2024 1

Wow @artemsheludko , 29 days ago I left this repo with less than 90 forks, good job man 👍 .
Sorry for my inactivity guys, other stuff kept me away from testing this feature.
Hopefully, I will find some time during this weekend.

from flexible-jekyll.

teobais avatar teobais commented on July 17, 2024 1

OH. MY. GAD.
We learned something today!
Many thanks @gutblog 😃
(Finally) closing (after 4 months 😆 )

from flexible-jekyll.

artemsheludko avatar artemsheludko commented on July 17, 2024

To be honest, I do not know. I never thought about it. If I find a solution I will write to you.

from flexible-jekyll.

teobais avatar teobais commented on July 17, 2024

Yes, I believe it would be a great step for this project to also support such a feature.
Let me know if you need any help.

from flexible-jekyll.

artemsheludko avatar artemsheludko commented on July 17, 2024

Okay, thanks!

from flexible-jekyll.

teobais avatar teobais commented on July 17, 2024

I will take a look until EOD and close the issue if it is the case!
Thanks a lot @kentonh anyways!

from flexible-jekyll.

teobais avatar teobais commented on July 17, 2024

Was a bit late (Friday hah), will do it today.

from flexible-jekyll.

teobais avatar teobais commented on July 17, 2024

Solution looks good, but how could we enhance it so that the image of the post is being displayed in the thumbnail? @kentonh
screen shot 2017-11-11 at 22 04 59

from flexible-jekyll.

kentonh avatar kentonh commented on July 17, 2024

I️ think I️ need to update the image url in the code. It’s working on my local fork, but it must be correct for file structure.

from flexible-jekyll.

teobais avatar teobais commented on July 17, 2024

@kentonh since I noticed it was merged, I thought it would be "plug'n'play", but of course, the project itself is mostly specific to Artem's details.
However, I'm still facing some trouble. Could you please help? https://github.com/toubou91/toubou91.github.io

from flexible-jekyll.

kentonh avatar kentonh commented on July 17, 2024

@artemsheludko I've made a new PR #12 to clean up the implementation.

from flexible-jekyll.

artemsheludko avatar artemsheludko commented on July 17, 2024

@kentonh Thank you for your time. Good job!

from flexible-jekyll.

teobais avatar teobais commented on July 17, 2024

Gonna check in a bit, thanks a lot!

from flexible-jekyll.

teobais avatar teobais commented on July 17, 2024

@kentonh for facebook and linkedin it seems to work fine, but for twitter I keep having the same issue, as depicted above.

from flexible-jekyll.

artemsheludko avatar artemsheludko commented on July 17, 2024

@toubou91 Thank you for your active participation in the project.

from flexible-jekyll.

teobais avatar teobais commented on July 17, 2024

Still the same. It doesn't work for twitter. I have merged the latest changes, but of course something might have gone wrong again. Could you please check?

from flexible-jekyll.

gutblog avatar gutblog commented on July 17, 2024

I think I just solved this issue with my pull request: #24

Example tweet with card: https://twitter.com/gutfeelingblog/status/962733501429592064

from flexible-jekyll.

teobais avatar teobais commented on July 17, 2024

I just synced my fork, but it still doesn't work for Twitter:

screen shot 2018-02-25 at 21 32 17

I mean, it only displays a card, instead of the post's image, as you showed in your last comment @gutblog

from flexible-jekyll.

gutblog avatar gutblog commented on July 17, 2024

@thodorisbais Please try your article's URL in https://cards-dev.twitter.com/validator and see if it shows you a valid card. AFAIK The validator will pull the most recent version of your site, so if you get a valid card using the validator, it should propagate to the rest of Twitter within a few minutes.

Otherwise, we might be able to help if you post the error from the Twitter validator, along with the final HTML meta tag snippet that it is reading in your site to try to construct the card.

from flexible-jekyll.

teobais avatar teobais commented on July 17, 2024

@gutblog the card is said to be properly validated from the site:

screen shot 2018-02-25 at 22 56 57

Am I configuring the post images in a wrong way maybe in my fork?

from flexible-jekyll.

gutblog avatar gutblog commented on July 17, 2024

@thodorisbais Your final, compiled code:

<meta name="twitter:image:src" content="/assets/img/git-logo.png">

Twitter images need to be absolute URLs if I am not mistaken (they must include your website's domain name). The culprit is your _config.yml file, which does not have your site's URL defined. Change your _config.yml line 6 from:

url: "" # the base hostname & protocol for your site, e.g. http://example.com

to

url: "https://thodorisbais.github.io" # the base hostname & protocol for your site, e.g. http://example.com

and your Twitter photo should start working!

from flexible-jekyll.

ricoms avatar ricoms commented on July 17, 2024

I'm trying to solve this issue nowadays, and I can't find how. I included in head.hml:

<meta name="twitter:card" content="{{ '/assets/img/twitter-card.png' | relative_url }}" />

and the image is available at that local path, although testing on twitter-validator I get this:

INFO:  Page fetched successfully
INFO:  14 metatags were found
INFO:  twitter:card = /assets/img/twitter-card.png tag found
ERROR: Invalid card name (Card error)

from flexible-jekyll.

ricoms avatar ricoms commented on July 17, 2024

I finally understood the problem, twitter:image only accepts absolute URL path to the image.

Here is the solution.

from flexible-jekyll.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.