calling previous controller about angular-route-segment HOT 10 CLOSED

If iam not wrong this issue is because the app-view-segment chain isnt flushed before a route change instead it is incrementally substituted which causes this issue. It would be great it this was fixed, cause this causes a lot of nasty issues.

Edit: Just found a fix for it #7
Edit2: Sorry it is a unrelated issue.

from angular-route-segment.

I am also getting the same problem .. here is my plunkr http://plnkr.co/edit/VPFOi7?p=preview

Please check console.logs to see the error

Here is the hierarchy

/listing ( cntrller :- listing_index )
-> /listing/myListing ( cntrller :- my_listing )
/promotion ( cntrller :- promotion_index )
-> /promotion/list ( cntrller :- promotion_list )

Initially the default url is /listing/myListing so it calls the following controllers ( listing_index,my_listing )

Now on clicking a link which takes to /promotion/list the following controllers are called ( promotion_index, my_listing, promotion_list )

why is my_listing getting called again ??

Please check console for the errors

from angular-route-segment.

+1, this should not be happening!
A workaround I found was to use a guard in the controller.

Compare $route.current.$$route.segment === $routeSegment.name

if ($route.current.$$route.segment === $routeSegment.name) {
//do stuff that should only happen when the
// *correct* segment is being initialized
}

PS: angular-route-segment v1.2.0

from angular-route-segment.

@jamie-pate that controller should never fired.

from angular-route-segment.

@naczu It is fired though :)

PS: this workaround only works for controllers that are used in the right-most segment.

EG: route: x.y.z <- code only works in controller for z

from angular-route-segment.

Ok, so. I figured out the 'correct' workaround for my problem. The issue for me was caused by calling $location.path(newPath) inside the constructor for a controller in one of the routes.

I was also mixing $routeProvider and $routeSegmentProvider and angular-route-segment wasn't updating the $routeSegment properly when the route wasn't a segment!

The solution was to not mix $routeProvider and $routeSegmentProvider

from angular-route-segment.

+1 .Suffering form the same issue . @jamie-pate do you have a plunkr to illustrate your solution ?

from angular-route-segment.

If you have a plunkr to illustrate your problem, I might be able to fix it?

from angular-route-segment.

Hi @jamie-pate , will this do :- http://plnkr.co/edit/VPFOi7?p=preview

from angular-route-segment.

That plunkr seems to work fine (no error messages)

It seems like $routeProvider is needed for redirects? I needed dynamic redirects so I ended up having to create a controller that did the job

   $routeSegmentProvider
     .when('/original/path', 'desired.segment_redirect')
     .when('/desired/segment', 'desired.segment')
     .segment('desired.segment_redirect', {
        template: '',
        controller: 'Redirect'
     })
     .segment('desired', {...})
     .within()
        .segment('segment', { ...})

    module.controller('Redirect',Redirect);
    function Redirect($location, persistentStorage) {
        var type = persistentStorage.get(type_key);
        $location.replace().path($location.path() + '/' + type);
    }

from angular-route-segment.