Giter Club home page Giter Club logo

Comments (5)

arsduo avatar arsduo commented on May 30, 2024

Hey,

It definitely shouldn't be doing that. I'll take a look at that soon.

Alex

from koala.

cbaclig avatar cbaclig commented on May 30, 2024

I'm in the process adding error handling for 500 responses and they should be up within the next few days. Do either of you have example Facebook URLs that currently return 500 responses that I can refer to for testing purposes?

from koala.

dacort avatar dacort commented on May 30, 2024

This URL should error out. https://graph.facebook.com/search?q=e3&type=post&since=2010-06-16T21:02:02%2b0000&until=2010-06-16T21:04:06%2B0000&limit=33

Side note: this is related to a bug on their side where the graph API returns an HTTP 500 in some cases if you provide a limit parameter greater than the available results.

from koala.

cbaclig avatar cbaclig commented on May 30, 2024

Thanks for the URL dacort.

I pushed a fix to master that raises an APIError for any server error response codes (500 or greater.) I haven't run into this problem myself, but I'm pretty sure Koala without this patch would have returned nil given the response from the broken URL above. The search URL returned an empty string for the body, which when parsed by API#api, would return [][0], the first element of an empty array, which is nil.

dacort, maybe you can take the patch for a spin in your app and let us know how it goes?

from koala.

arsduo avatar arsduo commented on May 30, 2024

Sounds like the issue is resolved; closing.

from koala.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.