Cannot use oidc-authservice along with kubeflow about oidc-authservice HOT 3 CLOSED

After some digging I find that the oauth callback handler was not properly registered:

router.HandleFunc(path.Join(c.AuthserviceURLPrefix.Path, OIDCCallbackPath), s.callback).Methods(http.MethodGet)

The OIDCCallbackPath was hard coded to /oidc/callback, not respecting the environment variable REDIRECT_URL.

Thus if the user did not set the REDIRECT_URL to /oidc/callback, the callbback will never be handled, resulting an authentication loop.

And the fix should be simple:

router.HandleFunc(c.RedirectURL.Path, s.callback).Methods(http.MethodGet)

May I make a PR for this?

from oidc-authservice.

Hello @edwardzjl, thanks for highlighting this bug. Although we give the option to set a custom value to the REDIRECT_URL envvar, this configuration will not affect the AuthService behavior as one would expect. Indeed, the fix you are proposing resolves this problem and I will start reviewing it right away.

from oidc-authservice.

You are indeed right about the authentication loop. We have traced it in the step where the browser makes a request to the REDIRECT_URL to exchange the auth code with tokens. However, because Authservice does not handle the REDIRECT_URL (handles only the <AUTHSERVICE_URL_PREFIX>/oidc/callback path), and because REDIRECT_URL is not listed in the SKIP_AUTH_URLS , AuthService will attempt to re-authenticate the request and essentially restarts the authentication process.

Just one question, which entity reports back the Too many redirections... message?

from oidc-authservice.