Firefox Jumps to Top of Page at Modal Launch about bootstrap-scroll-modal HOT 6 CLOSED

I'll take a look at the JS and see if I can get it to remain in the right spot. I think the behaviour you're looking for makes sense and should be the default.

from bootstrap-scroll-modal.

I changed the code

$('html').css({ 'overflow' : 'hidden' })

to

$('.container').css({ 'overflow' : 'hidden' })

and it seems to work in both chrome and firefox.

from bootstrap-scroll-modal.

Hmm. Ok, I'll look into how to best integrate that in then, as '.container' will not always be available to people using this. They may choose to not use Bootstrap's grid system and thus, not have that element.

I originally placed the overflow hidden on the body, rather than html, but overflow hidden on the body is not supported in IE6 and 7. Then again, who cares about IE! Haha. I may just revert back to placing the overflow hidden style on the body.

from bootstrap-scroll-modal.

Ah, yes, good point. I can't think of a more elegant solution at the moment.

Btw, I just want to thank you for this project. It's a huge improvement over the default bootstrap modal.

from bootstrap-scroll-modal.

I don't think it should be a hard fix, look for an update here shortly (although it seems like you have one now anyway). And thanks! I figured lots of people need dynamic height modals, so why not make it an option? I'm trying to get this code merged back into Bootstrap, so if all goes well it'll be in Bootstrap master soon enough.

from bootstrap-scroll-modal.

I've updated the JS to set the overflow property on the body rather than html. I haven't been able to find a fix for this that isn't super dirty and I really don't give a shit about IE6 or 7.

Thanks again for pointing this one out!

from bootstrap-scroll-modal.