Giter Club home page Giter Club logo

Comments (13)

arnellebalane avatar arnellebalane commented on July 20, 2024

Hi @jaklan , thank you for reporting this. I'll have to take a look. The popup on the page is meant to be a temporary solution while I work on a proper way to initiate PiP windows. Basically I will move the list of users from the extension popup UI directly into the Google Meet page itself, since opening a PiP window now requires a user gesture.

So sorry for this inconvenience. This behavior you encountered when clicking on "Show" was not something I found while testing this temporary solution. When you get the chance to try it again, can you help me check in your DevTools console if there are any errors logged? Thank you very much!

from google-meet-pip.

jaklan avatar jaklan commented on July 20, 2024

@arnellebalane maybe I'm doing sth wrong, but I have opened that view from the extension settings:
image
also turned on "Collect errors", but when I interact with the extension during the meeting - I see no logged interactions.

from google-meet-pip.

arnellebalane avatar arnellebalane commented on July 20, 2024

@jaklan In the DevTools console in the Google Meet page while you're on a call, do you see any errors related to PiP in there?

from google-meet-pip.

jaklan avatar jaklan commented on July 20, 2024

@arnellebalane no error, only this:
image
and when I hover over it - the "end call" button is highlighted.

from google-meet-pip.

jaklan avatar jaklan commented on July 20, 2024

I guess there's sth wrong here, because reading the code:

function enableHangupControl() {
  var control = getHangupControl();
  console.log(control);
  navigator.mediaSession.setActionHandler('hangup', function () {
    exitPictureInPicture();
    control.click();
    setTimeout(function () {
      var hangup = getHangupDialogControl();
      hangup.click();
    }, 500);
  });
  return function () {
    navigator.mediaSession.setActionHandler('hangup', null);
  };
}

I should get some "hangup control", but it seems the only thing I get is exitPictureInPicture();.

from google-meet-pip.

jaklan avatar jaklan commented on July 20, 2024

And if you find it helpful - that's my setup of icons in GMeet (maybe it's different in corporate GMeet or sth):
image

from google-meet-pip.

arnellebalane avatar arnellebalane commented on July 20, 2024

Hi @jaklan , and when you saw the button logged in the DevTools console, you still have the PiP window appear for a while and disappear right away?

from google-meet-pip.

jaklan avatar jaklan commented on July 20, 2024

@arnellebalane right, this log message and the quick "blink" of the PiP window happen almost at the same moment.

from google-meet-pip.

arnellebalane avatar arnellebalane commented on July 20, 2024

@jaklan Thanks for taking your time to check 🙏

from google-meet-pip.

arnellebalane avatar arnellebalane commented on July 20, 2024

Hi @jaklan , v1.2.0 of the extension is now published (#20). Hopefully it resolves your issue. Thank you! 🙇

from google-meet-pip.

jaklan avatar jaklan commented on July 20, 2024

@arnellebalane seems to work! 🎉

from google-meet-pip.

jaklan avatar jaklan commented on July 20, 2024

@arnellebalane today I tested it during the actual meeting with other participants - and unfortunately nothing changed, it still doesn't work - the PiP window appears for less than second in the bottom right corner, then disappears and no more happens. The difference is this time I don't get any logs from the extension.

from google-meet-pip.

jaklan avatar jaklan commented on July 20, 2024

@arnellebalane can I help with the debugging in any way? I'm really missing the working extension, I used to use it on a daily basis 😕

from google-meet-pip.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.