Giter Club home page Giter Club logo

Comments (2)

Arnavion avatar Arnavion commented on June 29, 2024

I understand that SimplePromise is a little different from SimpleSet and SimpleMap in that it's exposed more openly from the libjass API, whereas the other two are used completely internally. However I don't want to make the shim more complex than libjass itself needs it to be internally.

libjass only uses SimplePromise if global.Promise is not defined. If you want the promises that libjass's API returns to have more features, then you should give it such an implementation yourself, say, by including bluebird. For the same reason, if the browser / runtime has a native promise implementation, libjass will automatically use that.

If for whatever reason you're unable to have global.Promise be available for libjass to use at the time you load it (say your implementation is loaded after libjass is, or say it doesn't assign itself to global.Promise), you can still override the promise implementation used by libjass by setting libjass.Promise, eg: libjass.Promise = require("bluebird"); Make sure you do this before using any libjass API that returns you a promise, since I do not guarantee that an instance of SimplePromise works with instances of any other type of Promise.

from libjass.

Arnavion avatar Arnavion commented on June 29, 2024

This was fixed by 71151b2

Regarding:

Make sure you do this before using any libjass API that returns you a promise, since I do not guarantee that an instance of SimplePromise works with instances of any other type of Promise.

Since SimplePromise follows the Promises/A+ spec correctly, it should in fact work with instances of other types of Promise.

The recommendation to use a more featured and performant library still stands.

from libjass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.