Giter Club home page Giter Club logo

Comments (4)

ArnaudBarre avatar ArnaudBarre commented on July 18, 2024

Yeah when I wrote it the first time I knew this could be improve by looking at what is the value type. I though I would need type info from eslint-typescript but actually I think allowing any function and disabling the rest should be ok. I will change this :)

from eslint-plugin-react-refresh.

silverwind avatar silverwind commented on July 18, 2024

Return value analyzation would be awesome, yes.

from eslint-plugin-react-refresh.

silverwind avatar silverwind commented on July 18, 2024

The rule is still giving me trouble when the component is wrapped:

These work:

export function SVG() {
  return <svg/>;
}
export const SVG = () => {
  return <svg/>;
};

These all fail:

export const SVG = forwardRef(() => {
  return <svg/>;
});
export const SVG = memo(forwardRef(() => {
  return <svg/>;
}));
export const SVG = memo(forwardRef(function SVG() {
  return <svg/>;
}));

from eslint-plugin-react-refresh.

ArnaudBarre avatar ArnaudBarre commented on July 18, 2024

Added in 0.4.1

(I've decided to not use type analysis because this could block a lot of people (not the default with TS-ESLint), so I need to add cases one by one)

from eslint-plugin-react-refresh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.