Giter Club home page Giter Club logo

Comments (7)

fg2q1q3q avatar fg2q1q3q commented on June 7, 2024

the same with you,4.2 failed!

from luseenbottomnavigation.

dmytroKarataiev avatar dmytroKarataiev commented on June 7, 2024

Can confirm, Galaxy s4 API 17 doesn't work with this library.

from luseenbottomnavigation.

MR-Syn avatar MR-Syn commented on June 7, 2024

So, min SDK is not 15 as written on Android Arsenal, but 18 instead?
Thanks

from luseenbottomnavigation.

ChristopheVersieux avatar ChristopheVersieux commented on June 7, 2024

Works on API 15, but not 17. so MinSDK is not an issue.

from luseenbottomnavigation.

dmytroKarataiev avatar dmytroKarataiev commented on June 7, 2024

I've made some changes locally a long time ago to fix this. Can you post a stacktrace so I'll find the fix and post a PR?

from luseenbottomnavigation.

ChristopheVersieux avatar ChristopheVersieux commented on June 7, 2024

For me, issue is only in tablet mode, working fine on phone mode (app:bnv_tablet="true")

You can try in the emulator, nothing in logcat.

API 15: OK
API 17: NOT OK
Every other API: OK

Layout:

 <?xml version="1.0" encoding="utf-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
     xmlns:ads="http://schemas.android.com/apk/res-auto"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:baselineAligned="false"
     android:id="@+id/root"
     android:fitsSystemWindows="true"
     android:orientation="horizontal">
 
     <LinearLayout
         android:layout_width="320dp"
         android:layout_height="wrap_content"
          android:gravity="center"
         android:orientation="vertical" >
 
         <com.luseen.luseenbottomnavigation.BottomNavigation.BottomNavigationView
             android:id="@+id/bottomNavigation"
             android:layout_width="wrap_content"
             android:layout_height="0dp"
             android:layout_weight="1"
             app:bnv_tablet="true"
             app:bnv_active_text_size="@dimen/bottom_navigation_text_size_inactive"/>
 
         <com.google.android.gms.ads.AdView
             android:id="@+id/adView"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             ads:adSize="BANNER"
             ads:adUnitId="@string/banner_ad_unit_id" />
     </LinearLayout>
 
     <FrameLayout
         android:id="@+id/content_frame"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:layout_margin="@dimen/multipane_half_padding" />
 </LinearLayout>

from luseenbottomnavigation.

ChristopheVersieux avatar ChristopheVersieux commented on June 7, 2024

New finding: Do not display issue on API 17 is caused by: android:layout_width="wrap_content" (for tablet mode) android:layout_width="Somethingdp" is fine.

from luseenbottomnavigation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.