Giter Club home page Giter Club logo

Comments (14)

jjhelmus avatar jjhelmus commented on June 15, 2024

@josephhardinee Very cool, would this also include the ability to read UF files without RSL? I have the beginnings of a module that can read UF files. I'll post it somewhere if it helps.

from pyart.

josephhardinee avatar josephhardinee commented on June 15, 2024

I'd just planned on writing UF, though I have a UF reader written also(RSL doesn't work with NCAR format UF files a lot of the time). I can push it into another branch and we can compare and merge the codes.

from pyart.

jjhelmus avatar jjhelmus commented on June 15, 2024

I'll start a UF branch in the next few days for the codes I have and add a link here.

from pyart.

jjhelmus avatar jjhelmus commented on June 15, 2024

@josephhardinee Any updates on this work?

from pyart.

josephhardinee avatar josephhardinee commented on June 15, 2024

It kind of got strangled by dissertation writing. Hopefully I should be able to revisit it very soon.

from pyart.

gamaanderson avatar gamaanderson commented on June 15, 2024

Is some one working in this issue? Responding from a request from Simepar, I would like to get to it.

from pyart.

jjhelmus avatar jjhelmus commented on June 15, 2024

@josephhardinee mentioned he had some code for this at the AMS radar meeting.

Since I added support for reading UF and am now well versed in the format I can try to code something up this afternoon.

from pyart.

jjhelmus avatar jjhelmus commented on June 15, 2024

In progress work on a UF writing appears in the jjhelmus/pyart/uf_write branch. This branch will rebased when complete.

from pyart.

jjhelmus avatar jjhelmus commented on June 15, 2024

Closed with the merging of #388

from pyart.

gamaanderson avatar gamaanderson commented on June 15, 2024

Nice work @jjhelmus

@TulipaSilva can you please confirm that TITAN is recognizing this UF-files. If you don't have the time, ask someone else, Beneti is aware of that.

from pyart.

jjhelmus avatar jjhelmus commented on June 15, 2024

Let me know if there are any issue with UF writing that you find. Code coverage is 100% but it could still use some testing with real world files. Two other things to keep in mind are:

  • Py-ART is writing UF files with 2-byte padding around each record, this is consistent with the files RSL creates but may not be supported by all software. If you need 1-byte or no padding files open an issue and I should be able to add support for these files without too much work.
  • UF writing in Py-ART relatively slow, probably no good way around this without some serious optimization.

from pyart.

gamaanderson avatar gamaanderson commented on June 15, 2024

BUG: in line 265 it should be / 1000 and not * 1000, this is causing overflow and consequent error while packing. Also in line 266 I believe 'range_start_m' is just the decimal part of the range, otherwise a start range of 33 km will overflow and I don't see a reason for repeating the information. Sorry it took so long for reporting this bug.

Also I would have found more comfortable, fields not present in uf_field_names to be excluded from writing, and not causing an KeyError: in line 150. But you probably have your reasons for not doing so.

from pyart.

jjhelmus avatar jjhelmus commented on June 15, 2024

Thanks @gamaanderson for catching these. All three of these are bugs, I will have a fix for them shortly.

from pyart.

jjhelmus avatar jjhelmus commented on June 15, 2024

PR #400 fixes all three of these bugs.

from pyart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.