Giter Club home page Giter Club logo

Comments (5)

burdges avatar burdges commented on July 17, 2024 1

It's all benchmarking artifacts afaik: We'd seriously fucked up benchmarks, the arkworks benchmarks were not perfect either, and separately criterion was making it look like arkworks bechmarks reported the same problem. I think @swasilyev fixed the arkworks benchmarks. I hopefully convinced him arkworks needs a smaller MSM1024 bechmark for other reasons, which should avoid criterion issues, even on people's laptops. Also @achimcc will fix our messed up benchmarks.

from curves.

burdges avatar burdges commented on July 17, 2024

I'll close this for now since @swasilyev pointed out that criterion does not handle slow benchmarks well: bheisler/criterion.rs#320

We'll sort this out internally and reopen if necessary. It maybe worth having some smaller MSM benchmarks too.

from curves.

swasilyev avatar swasilyev commented on July 17, 2024

Individual muls:

Arithmetic for Bls12_381::G1/Scalar Multiplication
time: [191.29 µs 194.11 µs 199.25 µs]

Arithmetic for Bls12_381::G2/Scalar Multiplication
time: [692.69 µs 708.57 µs 725.30 µs]

1024-MSM:

MSM for Bls12_381::G1 time: [24.212 ms 24.980 ms 25.818 ms]

~8x faster than individual

MSM for Bls12_381::G2 time: [72.097 ms 72.759 ms 73.431 ms]

~10x faster

from curves.

swasilyev avatar swasilyev commented on July 17, 2024

I'll close this for now since @swasilyev pointed out that criterion does not handle slow benchmarks well:

@swasilyev actually didn't mean anything like that. What he meant is that you should respect other's time and double check before posting your exciting findings

from curves.

Pratyush avatar Pratyush commented on July 17, 2024

This is surprising; do you think this is because of the multi-threading overhead? Do you have an idea of the cost if you turn off parallel?

from curves.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.