Comments (7)
sheesh i missed this in the last update. okay i have an update coming this weekend anyway. I'll do it then.
from arksavegametoolkitnet.
Okay ... I'll get those merged in tomorrow.
from arksavegametoolkitnet.
Did you have the time to look at it ?
from arksavegametoolkitnet.
Do you think you could merge these changes? I have running with those for the past 3-4 months without a probleme.
from arksavegametoolkitnet.
Great. Thank you very much.
from arksavegametoolkitnet.
@flagoss can you review this PR that mentions this issue (I could not reference you directly as a request reviewer)
Though I can see in your commit that you referenced that you're handling some casting scenarios with generic in the ArkCreature, I feel the underline issue is related to the underline types as they are being loaded and read.
and actually, from that referenced commit alone, it's unclear to me how a negative value in a signed byte could be casted to unsigned byte without erroring.. potentially you have more changes for me to review on than that one commit alone ?
from arksavegametoolkitnet.
My knowledge about programmation is limited. I did those modification last year. The only thing I changed is sbyte to byte. I am running with my modification since then. My servers are all with lvl600 wild dinos and we had no issue with this modification. But like I said I am not a programmer. I don't understand everything you are saying.
from arksavegametoolkitnet.
Related Issues (8)
- Game- and cluster-update methods should not depend on class name matching
- Ragnarok incomplete map
- Crystal Isles location multipliers are wrong for the release map HOT 2
- Support hibernation entries from singleplayer savegames HOT 4
- arkbot i get error faild
- Incorporating ark-savegame-toolkit changes
- Check for "The Volcano" implementation ;)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arksavegametoolkitnet.