Giter Club home page Giter Club logo

Comments (7)

 avatar commented on May 24, 2024 1

sheesh i missed this in the last update. okay i have an update coming this weekend anyway. I'll do it then.

from arksavegametoolkitnet.

 avatar commented on May 24, 2024

Okay ... I'll get those merged in tomorrow.

from arksavegametoolkitnet.

flagoss avatar flagoss commented on May 24, 2024

Did you have the time to look at it ?

from arksavegametoolkitnet.

flagoss avatar flagoss commented on May 24, 2024

Do you think you could merge these changes? I have running with those for the past 3-4 months without a probleme.

from arksavegametoolkitnet.

flagoss avatar flagoss commented on May 24, 2024

Great. Thank you very much.

from arksavegametoolkitnet.

brcaswell avatar brcaswell commented on May 24, 2024

@flagoss can you review this PR that mentions this issue (I could not reference you directly as a request reviewer)

Though I can see in your commit that you referenced that you're handling some casting scenarios with generic in the ArkCreature, I feel the underline issue is related to the underline types as they are being loaded and read.

and actually, from that referenced commit alone, it's unclear to me how a negative value in a signed byte could be casted to unsigned byte without erroring.. potentially you have more changes for me to review on than that one commit alone ?

from arksavegametoolkitnet.

flagoss avatar flagoss commented on May 24, 2024

My knowledge about programmation is limited. I did those modification last year. The only thing I changed is sbyte to byte. I am running with my modification since then. My servers are all with lvl600 wild dinos and we had no issue with this modification. But like I said I am not a programmer. I don't understand everything you are saying.

from arksavegametoolkitnet.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.