Giter Club home page Giter Club logo

Comments (4)

josevalim avatar josevalim commented on May 26, 2024 1

Hi @arjan, just to clarify, the change was a bug fix as it was impossible to distinguish a bodyless clause from a function that returned nil. This could even be the source of a bug in this lib. For example, if someone did:

@decorator Bla
def foo(bar, baz)

def foo(baz, baz) do
  ...
end

Note however that not only do/rescue is possible, but do and any of rescue/catch/after. So you probably want to check the Elixir version for v1.5+ and do nothing if the body is nil and, if a keyword list, you traverse all pairs.

from decorator.

arjan avatar arjan commented on May 26, 2024

Thanks for the report. I never use rescue on the function level. It seems it always worked magically, but in Elixir 1.5 they changed the AST for these constructs. I've updated the code.

from decorator.

arjan avatar arjan commented on May 26, 2024

Thanks I'll check that out and make sure it has coverage!

from decorator.

asummers avatar asummers commented on May 26, 2024

Thank you @josevalim and @arjan ! ❤️

from decorator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.