Change iconv-corefoundation to be in `optionalDependencies` about dmg-license HOT 2 CLOSED

The dependency on iconv-corefoundation isn't actually optional. Dmg-license doesn't work at all without it. It's needed to convert input text into the Classic Mac OS character encodings expected in DMG license data.

I don't think that will help you anyway. Even if dmg-license did the character encoding conversion in some other, platform-independent way and didn't depend on iconv-corefoundation, dmg-license also requires the hdiutil program that only exists on macOS, so it still won't work on any other platform. For this reason, the package.json for dmg-license says it requires macOS (darwin), same as the package.json for iconv-corefoundation.

I see that electron-builder currently has a non-optional dependency on dmg-license. I'm not sure why—unlike dmg-license, electron-builder is useful on platforms other than macOS—so you might want to ask them to make their dependency on dmg-license optional.

Edit: It looks like I was reading the wrong package.json. Electron-builder depends on dmg-builder, and dmg-builder's dependency on dmg-license is optional, which should be fine.

People now seem to be saying that this is actually an issue with pnpm's dependency handling. Shall I close this issue, then?

from dmg-license.

Thank you for the in-depth explanation!

Yes, the creator of pnpm confirmed it's related to their dependency handling, closing this ;)

from dmg-license.