Giter Club home page Giter Club logo

Comments (3)

jessesuen avatar jessesuen commented on May 20, 2024

The problem is during embedding. Here is a section of the embedded template for the selenium-server fixture:

{
  ...
  "selenium": {
    "template": {
      "type": "container",
      "version": "1",
      "name": "selenium-server",
      "description": "Base selenium container for selenium firefox and chrome",
      "id": "5437d66f-0c90-5245-5cd4-dd2ae7252368",
      "repo": "https://github.com/argoproj/appstore.git",
      "branch": "master",
      "revision": "b6441b788e8f9ae142238ab71f7fda21cfdd411f",
      "inputs": {
        "parameters": {
          "BROWSER": null
        }
      },
      "resources": {
        "mem_mib": "1024",
        "cpu_cores": "0.1"
      },
      "image": "selenium/standalone-%%inputs.parameters.BROWSER%%-debug:latest"
    },
    "status": 0,
    "status_string": "",
    "cost": 0,
    "create_time": 0,
    "launch_time": 0,
    "init_time": 0,
    "average_init_time": 0,
    "end_time": 0,
    "wait_time": 0,
    "run_time": 0,
    "average_runtime": 0,
    "artifact_tags": "",
    "is_submitted": false
  }
}

Notice that the container has inputs.parameters.BROWSER, but there is no arguments field (as a peer to template). There should be. The bug is is that during embedding of workflows, I neglect to apply the same inferring of template arguments that I do with workflow steps.

from argo-workflows.

jessesuen avatar jessesuen commented on May 20, 2024

Fixed in 1.0.1 and 1.1

from argo-workflows.

jessesuen avatar jessesuen commented on May 20, 2024

NOTE: after upgrading to the build with the fix, a cluster which had already attached the appstore repo, will need to disconnect and reconnect the repo to reingest the correctly embedded template.

from argo-workflows.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.