Comments (1)
Follow-up to this Slack thread
- The
secure
variable is set to false becauseopts.TLSConfig
is nil, indicating that Argo Server is not terminating TLS. Instead, a reverse proxy is used to terminate TLS. So https://github.com/argoproj/argo-workflows/blob/v3.5.5/server/auth/sso/sso.go#L345-L348 ends up beinghttp
when infact we are usinghttps
.
We could potentially use the request's protocol to determine this.
But secure: false
has other implications, like the Cookie setting and potentially others that we should be careful around and ensure properly handle ingress TLS termination.
EDIT: Here's another redirect line that depends on it that should be changed too.
from argo-workflows.
Related Issues (20)
- option to not auto-add tolerations HOT 3
- reduce pod definition size HOT 3
- 3.5 Pagination in workflow list page not working HOT 5
- Dependency between CronWorkflows HOT 5
- 3.5.6+ `items.status.nodes` disappeared from `/api/v1/workflows` endpoint for completed Workflows HOT 5
- Specify external artifacts repo with azure blob HOT 1
- DOM text reinterpreted as HTML in `workflow-logs-viewer.tsx` HOT 2
- Fix incorrect conversion between integer types in `parametrizable.go` HOT 1
- Possible clear-text logging of sensitive information in CLI `token.go` HOT 2
- Archived workflows deletion with GC stopped working after move to namespace install HOT 6
- Devcontainer `Permission denied` error during `chown`
- Unable to run Controller locally on Arm mac M1 HOT 1
- UI: Open custom `links` in new tab or with router navigation depending on address HOT 1
- `MetricsError`: custom metrics at Workflow-level unable to resolve output variables HOT 1
- support `retryPolicy` combination HOT 6
- `podSpecPatch` not applied when configured in `workflowDefaults` and workflow is submitted from template HOT 1
- `podSpecPatch` doesn't evaluate `retries` when defined at workflow spec HOT 5
- feat: support fish completion
- Use trusted distribution for Python SDK publishing
- 3.5.7 Server pods are crashing after upgrade HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from argo-workflows.