Giter Club home page Giter Club logo

Comments (2)

agilgur5 avatar agilgur5 commented on June 2, 2024 1

The warnings are concerning two external libraries, autolinker and argo-ui.

Yea they're both warnings you can ignore. There's also SCSS warnings on deprecated syntax in the Foundation UI library. All of them are from deps so we can't really fix them.

I didn't want to add an ignore in the webpack config though as they can become errors and so we should be mindful of them, particularly when doing dep upgrades or changing config. For instance, #12516 (comment) has a test error due to this. #12516 also removes the autolinker dep.

argo-ui is not importing things correctly.

Yea IIRC it was written before the import type syntax existed and is on an older version of TS, Webpack, etc.
It also exports raw TS, which is why the error occurs downstream in this codebase, and why I haven't been able to upgrade Workflows' TS version or make Workflows' tsconfig more strict 😕 The new JSR's auto-compilation looks potentially useful for that portion of the problem

argo-ui is effectively deprecated and barely maintained (I'm the only person who really checks it, but I can't merge my own PRs) unfortunately; see also argoproj/argo-ui#453

(For reference, I've been an active contributor for about a year now, so much of this history predates me)

from argo-workflows.

agilgur5 avatar agilgur5 commented on June 2, 2024 1

argoproj/argo-ui#509 unblocked argoproj/argo-ui#552 which unblocked #12516 and now the popup warnings have been resolved plus several others (install warnings and console warnings have been reduced as well)!

from argo-workflows.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.