Comments (1)
svghadi
commented on August 30, 2024
I did some digging, if the the repoURL contains oci scheme, the getCAPath func will return the correct CA cert even if the url contains path.
argo-cd/pkg/apis/application/v1alpha1/repository_types.go
Lines 239 to 240 in 3d77d9c
However, when I try to set the oci scheme in the url, eg. oci://my-registry.default/helm-charts, the creation of the repo fails with OCI Helm repository URL should include hostname and port only from cli. From UI, the repo is created but oci:// is truncated.
PR #5888 introduced this change to disallow oci scheme in URL. @alexmt, I noticed that you implemented this change. Do you think this can be reverted as helm now supports oci:// prefix?
https://helm.sh/docs/topics/registries/#other-subcommands
Support for the oci:// protocol is also available in various other subcommands. Here is a complete list:
An alternative simple solution to fix this bug could be to explicitly add oci:// scheme during fetching of the CA certs if the repo has EnableOCI set to true so that the url parsing correctly detects the hostname.
from argo-cd.
Related Issues (20)
- Support for OCI (Oracle Cloud Infrastructure) Integration to Manage OKE Clusters
- Unable to sync helm chart with OCI dependency hosted in private docker.io HOT 1
- Start watch {...} Failed to watch {...} loop when target cluster paused
- Repo URL in application summary page will not open a new tab HOT 1
- Enable git submodule HOT 4
- Ability to update cluster information including labels HOT 5
- changing destination from server to name causes constant app refresh HOT 5
- Use transforming informer for cluster cache
- Application controller can run out of disk space on '/dev/shm', when deploying concurrently to a large number of clusters, or with many large manifests
- ArgoCD does not set OutOfSync status after editing a deployed resource HOT 1
- [UI] App of Apps 'Go-To-Parent' Button on Application Details View HOT 6
- Argo CD versions release-2.9 and release-2.10 are pulling outdated versions of github.com/hashicorp/go-retryablehttp.
- Can't add docker-desktop cluster
- Need to disable pruning in my application in order to user can not use that option
- applicationSet syncPolicy docs vs CRD mismatch
- [Notifications] Make GH Check Runs part of ArgoCD Notifications natively
- Add Kubectl Option support like disable-compression
- API spec update - support just patching a single option versus entire app manifest HOT 4
- Test Health of namespace before other object when syncPolicy is set to syncOptions:[ CreateNamespace=true ]
- Conflicting result from `argocd admin settings rbac can` and `argocd account can-i` for logs RBAC
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from argo-cd.