Giter Club home page Giter Club logo

Comments (3)

jkrukowski avatar jkrukowski commented on May 24, 2024 1

I see, makes sense. In this case, we should not only run our tests in parallel but also run each platform in parallel. If its taking longer than 20 minutes that's too long for unit tests imo.

ok, let me try to do it then

from whisperkit.

jkrukowski avatar jkrukowski commented on May 24, 2024

Looks like here the reason is a timeout, see here https://github.com/argmaxinc/WhisperKit/actions/runs/8525582362?pr=99

Screenshot 2024-04-15 at 13 49 28

unit tests on CI seems to be configured that way

timeout-minutes: 20

Should we increase the timeout (to e.g. 30 minutes)? or we could parallelise tests for each platform

from whisperkit.

ZachNagengast avatar ZachNagengast commented on May 24, 2024

I see, makes sense. In this case, we should not only run our tests in parallel but also run each platform in parallel. If its taking longer than 20 minutes that's too long for unit tests imo.

from whisperkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.