Comments (6)
Uhhh unrarall made me a horror situation, it made huge mess, you need to fix this issue.
I'm sorry unrarall
deleted your files unexpectedly. However this is open source. We don't need to do anything. Demanding things get fixed is a great way to go about getting your issues ignored.
However the behavior describe doesn't seem desirable so we should try to fix it. I need to have a chat with @arfoll first though about setting up some basic testing infrastructure so we don't introduce regressions.
from unrarall.
lmao
from unrarall.
@delcypher I know sorry I was in shock, I didn't demanded I made urgency about serious problem.
https://mega.nz/#!R5V0iQxD!eqey5KB9peZLMYtHVp1SuCL-Y1GugEgznINnTEHbImA
https://mega.nz/#!U4VBCQaK!-c6L0vcNhKrV_Q76f5T_YLtb7XiDbWjnXaRqJCUi6PU
https://mega.nz/#!A9l0hSTK!JDdgNW49990n8DyjiUgo-C95XTBOtseSqkbQVRpkOJ8
https://mega.nz/#!lh1TTAiK!AZNMiOAMVAJi-mmGPqr58OOs9EW2zWUuj2ckfk1hddc
https://mega.nz/#!cgtxgILS!dc8E-bMACXqpQlq7CVIywFfInzwfzuh6QAX0P4Pezp4
These were the example files, one of these "london.has.fallen.2016.1080p.bluray.x264-drones.subs.rar", has acceptable naming and archiving type, other were with the idiotic archiving and naming.
from unrarall.
hi @loa11, thanks for reporting this and apologies it's caused you issues. If I understand the issue, unrarall considers the subs.rar successfully extracted so then removes everything that looks like a rar archive, including your unfinished stuff.
Unfortunately I'm not sure how to best treat the issue, did you have cksfv running? It would possibly have worked (not 100%) but we could definately introduce strict cksfv checking that would fix it. If you run unrarall with --dry
what happens?
@delcypher I did create part of a test harness at one point but never completed it, hopefully it's still around somewhere or we can start from scratch.
from unrarall.
Most of rared subs had sfv file and almost every rared movie had own sfv set.
Here is the direct example
http://pastebin.com/udTzDqDp
In the mega links there is actual sub rar
If you look inside the sub rar you will see hail.caesar.2016.1080p.bluray.x264-drones.rar and hail.caesar.2016.1080p.bluray.x264-drones.idx
Unrarall would sfv check hail.caesar.2016.1080p.bluray.x264-drones.subs.sfv firstly and after that it would unrar hail.caesar.2016.1080p.bluray.x264-drones.subs.rar which would unpack hail.caesar.2016.1080p.bluray.x264-drones.rar and hail.caesar.2016.1080p.bluray.x264-drones.idx.
It would overwrite original rar base file hail.caesar.2016.1080p.bluray.x264-drones.rar size 97656K with hail.caesar.2016.1080p.bluray.x264-drones.rar size 5737915.
In the case someone decide to use force syntax with unrarall, complete mkv and all the rar files would be destroyed because cleaner would delete all rar files after, but if you don't use force syntax, just the base rar file is overwritten with the wrong sub base file.
I see few possible solutions, one is that unrarall ignores all the rars with naming *subs.rar or that unararall search for *subs.rar and *subs.sfv and to remove them into the Subs folder or as the final solution is that unrarall skips overwriting.
from unrarall.
wasn't this fixed in #40 ?
And it's confusing.. because that PR says it was merged in the last comments.. yet it doesn't appear to have been merged.. is this problem patched or not?
If so then this issue should be closed?
from unrarall.
Related Issues (20)
- Corrupt File or wrong password Error HOT 2
- FR: Move subtitle files to main dir HOT 2
- Mac sed, the special snowflake... HOT 3
- Clobbering files on extraction and skipping already extracted files HOT 1
- extraction fails if source folder name has spaces HOT 5
- wishlist HOT 1
- provide example usage in readme.md HOT 2
- [BASH 3] Relative path gives error message about UNRARALL_OUTPUT_DIR not being a directory HOT 4
- Egrep style regular expressions break finding rar files in certain cases. HOT 1
- Valid rar file invalid mime type HOT 2
- .r00 files not found HOT 1
- Does not obey --skip-if-exists. HOT 2
- Feature request: Option to rename output file to parent directory HOT 1
- Allow 7zip to extract .ISO Files
- Only 1 working HOT 1
- Extracting files into a path named after the file
- Get error at unrar
- Unnrar from subfolders and rename extracted file to parent folder name HOT 1
- .zip support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unrarall.