Comments (8)
Accept-Language
has lots of problems, but it's better than nothing. I'm 👍 on this.
from api-cdi.
This is in on dev, it'll go out at some point in the future when @lye does a deploy.
from api-cdi.
That was fast. I thought this was low priority? Not complaining, just wondering.
from api-cdi.
It was a tiny change and I had some spare time.
from api-cdi.
It's kind of a rough header to implement according to the spec. Do we get support for multiple values? Quality values?
Accept-Language: da, en-gb;q=0.8, en;q=0.7
from api-cdi.
It's not all that bad, really. We have an existing shared implementation in the core of our web application code, so all I did was replace the API specific ?lang=xx
parsing with the one in core.
It'll prefer ?lang=xx
values, but fallback to the Accept-Language
header (including support for multiple values and quality levels). If none of those match it defaults to english.
from api-cdi.
Sweet! That's awesome.
from api-cdi.
This is deployed.
from api-cdi.
Related Issues (20)
- /v2/gliders does not respect the requested language HOT 1
- "binding" is missing for equipped bags
- /v2/characters endpoint - stat selectable items sometimes missing prefixes HOT 1
- Missing bits details in (some) No Quarter achievements
- Missing home instance nodes in /v2/account/home/nodes
- Invalid Link response header from /v2/recipes/search
- New Exposure: Looking for Group
- Unknown leading one in all worlds object at wvw matches end point
- /v2/guild/:id/log: expose guild stash id for withdraw/deposit operations
- GraphQL interface as an alternative to REST for public client development. HOT 1
- Three recipes who's output item reports invalid HOT 1
- Missing items from /v2/items and /v1/item_details.json
- /v2/characters/:id/quests not showing completed quests
- Mumble link: Inconsistent AvatarPosition updates
- /v2/items/:id missing new EoD flag for Research Kit salvage
- Character equipment is incomplete with newer equipment slots
- Why skills api not show cooldown time?
- /v2/account/wizardsvault/daily Returns inaccurate data until after logging in HOT 1
- Render service EoD elite specialization's icons resolution doesn't match others'
- Add selected WvW guild to /v2/account HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from api-cdi.