Giter Club home page Giter Club logo

Comments (18)

lye avatar lye commented on July 19, 2024

I think the API server is on some weird clock or something. There's a fix in the works but I'm not sure I can land it until December due to holidays and such.

from api-cdi.

poke avatar poke commented on July 19, 2024

I don’t really know where this NA vs EU timing idea comes from, since the reset time of dailies has always been midnight UTC for everyone (it has been like that since GW1).

I have been tracking the dailies using the API now for three weeks, confirming it in-game every day on both a EU and NA account. What I saw all the time is that the daily API simply shows the dailies for the next day. This happens consistently at any given time. As such, to get the current dailies, I always look at the ones from the day before. This hasn’t shown me the wrong dailies even once.

Now I haven’t been around at midnight UTC often to see if the API switches exactly at that point, but the few times I was awake around that time confirmed that it correctly works as described above, always listing tomorrow’s dailies.

Since I think listing tomorrow’s dailies is particularly useful, I would not like to see this fixed to show today’s dailies. I could totally live with how it is right now, but a good alternative would probably to have two separate endpoints for today’s and tomorrow’s dailies.

from api-cdi.

AlexSwensen avatar AlexSwensen commented on July 19, 2024

I agree that it would be nice to see tomorrows daily's as well as the current ones.
As for the point at which the API switches, it happens at midnight UTC as well.

from api-cdi.

atomicptr avatar atomicptr commented on July 19, 2024

Interesting... why do we even have the [na, eu] split then? I was assuming that they do have different reset times.

from api-cdi.

AlexSwensen avatar AlexSwensen commented on July 19, 2024

I am assuming its like lye said, and that there is a problem with the API server thats serving that information. As for the NA vs EU times, i can't confirm that. I am on NA, and haven't yet bothered to do anything with an EU account as of yet.

from api-cdi.

poke avatar poke commented on July 19, 2024

You seem to miss my point: There is no problem with the API server. The only “problem” would be that it always shows tomorrow’s dailies instead of todays…

why do we even have the [na, eu] split then?

That’s kind of my question. Why was this apparent split ever brought up (and is suggested as a possibly coming solution)? Where did this come from? There is no difference in-game between NA and EU as far as dailies go. They reset always at midnight UTC, regardless of your server location. I and hundreds other people can confirm that. And as for the API, it seems that it’s perfectly in sync with that reset time at midnight UTC too.

from api-cdi.

AlexSwensen avatar AlexSwensen commented on July 19, 2024

I believe this issue is much more along the lines of which dailies are shown (tomorrows vs todays) rather than any apparent "split" from NA vs EU. Along those lines, i do not miss your point, however i believe that becomes a moot point with a resolution to this issue.

from api-cdi.

lye avatar lye commented on July 19, 2024

I don’t really know where this NA vs EU timing idea comes from, since the reset time of dailies has always been midnight UTC for everyone (it has been like that since GW1).

Why was this apparent split ever brought up (and is suggested as a possibly coming solution)? Where did this come from?

That was my bad -- there isn't any difference for daily resets. I got confused because there is a difference for WvW reset times. I'm going to remove that bit since it doesn't make any sense.

I believe this issue is much more along the lines of which dailies are shown (tomorrows vs todays)

The main issue, as I see it, with displaying tomorrow's dailies is that they might change (e.g., due to a patch).

Anyway, the backend fixes are in as of an hour ago, so I should have the endpoint spitting out the correct data sometime this week.

from api-cdi.

poke avatar poke commented on July 19, 2024

Okay, thanks a lot for claring that up :)

I should have the endpoint spitting out the correct data sometime this week

If you do that, please leave another endpoint that still gives tomorrow’s dailies. I’ve found it a lot more useful to get tomorrow’s dailies than today’s (since those are also visible in-game, and I also can get those by looking at stored results from the day before).

Of course I can understand that we need to have an endpoint for the current dailies, but I would really like to keep the ability to look ahead :)

from api-cdi.

lye avatar lye commented on July 19, 2024

If you do that, please leave another endpoint that still gives tomorrow’s dailies.

Should be pretty straightforward. Suggestion for an endpoint name? /v2/achievements/tomorrow or /v2/achievements/daily/tomorrow or /v2/achievements/daily?tomorrow? None of them really feel right to me. @tivac halp.

from api-cdi.

dr-ishmael avatar dr-ishmael commented on July 19, 2024

/v2/achievements/daily/current and /v2/achievements/daily/next?

Would it possible to parameterize it to pull achievements for N days in the
future? /v2/achievements/daily?offset=N (default N = 0)

On Tue, Dec 1, 2015 at 12:44 PM, lye [email protected] wrote:

If you do that, please leave another endpoint that still gives tomorrow’s
dailies.

Should be pretty straightforward. Suggestion for an endpoint name?
/v2/achievements/tomorrow or /v2/achievements/daily/tomorrow or
/v2/achievements/daily?tomorrow`? None of them really feel right to me.
@tivac https://github.com/tivac halp.


Reply to this email directly or view it on GitHub
#120 (comment).

from api-cdi.

tivac avatar tivac commented on July 19, 2024

@lye sorry I don't have any URL structure I love for that.

/v2/achievements/daily and /v2/achievements/daily/next seem the most innocuous to me. We shouldn't show multiple days in advance IMO since that isn't exposed in the game UI and may change due to content updates.

from api-cdi.

atomicptr avatar atomicptr commented on July 19, 2024

Not sure if it's that bad if a daily in the future changes because the API will also update if that happens.

from api-cdi.

lye avatar lye commented on July 19, 2024

Just as a note; I deployed a new version of the code that should behave correctly at reset. Gonna keep an eye on it and make sure it does the right thing in the live environment.

from api-cdi.

poke avatar poke commented on July 19, 2024

I noticed that the /daily endpoint already switched to today’s daily a few hours ago. Does that new deployment already include an endpoint for tomorrow’s dailies?

from api-cdi.

lye avatar lye commented on July 19, 2024

Not yet, no. I'll probably add it later this week.

from api-cdi.

atomicptr avatar atomicptr commented on July 19, 2024

Just confirmed that the data is indeed correct now, thanks ;).

from api-cdi.

lye avatar lye commented on July 19, 2024

Just confirmed that it updated properly on reset too. Hurrah for no surprises on live today.

from api-cdi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.