Giter Club home page Giter Club logo

Comments (5)

lye avatar lye commented on June 19, 2024

I think these are the hidden minor traits -- the ones that affect whether or not you can equip the elite-only weapons. We're currently excluding them from /v2/traits and /v2/specializations because they aren't displayed in-game anymore. Will look into removing them from /v2/characters as well.

Thanks for the report <3

from api-cdi.

Eearslya avatar Eearslya commented on June 19, 2024

The weapon proficiency minor traits are actually still shown in game, in the corner of the elite spec's icon.

from api-cdi.

lye avatar lye commented on June 19, 2024

Ah nuts, they added them back at some point I guess.

I'll figure something out -- I'm thinking about adding them back to /v2/traits, then maybe adding an additional field to /v2/specializations to indicate they're implicit traits. I don't want to add them back to the minor_traits array since ... having four minor traits feels inconsistent?

Thoughts?

from api-cdi.

Eearslya avatar Eearslya commented on June 19, 2024

I'm fine with either, personally. Either way they're easily discernable, since the weapon proficiency trait is always tier 0. Not sure what I'd call the new field though. Perhaps weapon_trait?

from api-cdi.

lye avatar lye commented on June 19, 2024

Okay, this should be sorted. Let me know if further changes are needed!

from api-cdi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.