Giter Club home page Giter Club logo

Comments (3)

ardan-bkennedy avatar ardan-bkennedy commented on August 10, 2024

Hmmmm. Right the handler will send the OK response, and then the middleware will unwind. There is a chance the Commit fails. In that case, the error middleware would log the error, the call to send a second response would happen, before closing the connection. Until we actually try it, I'm not 100% sure. I am going to try this now.

from service.

ardan-bkennedy avatar ardan-bkennedy commented on August 10, 2024

@suppakorn-dev you opened a can of worms. hahahahaha

I have made changes to support the middleware rolling back and responding properly. It required changes to the web package and protocol layer code. The code is better for it.

Thanks!

from service.

PH9 avatar PH9 commented on August 10, 2024

Fixed with #387 🎉

from service.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.